emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org 1f1d8f909a: org-element-cache-map: Do not disable G


From: ELPA Syncer
Subject: [elpa] externals/org 1f1d8f909a: org-element-cache-map: Do not disable GC
Date: Sat, 3 Sep 2022 22:57:49 -0400 (EDT)

branch: externals/org
commit 1f1d8f909aea6a12a9127b8f7d253a979b0b4568
Author: Ihor Radchenko <yantar92@gmail.com>
Commit: Ihor Radchenko <yantar92@gmail.com>

    org-element-cache-map: Do not disable GC
    
    * lisp/org-element.el: Do not disable GC.  This can make Emacs hang in
    some particularly bad scenarios.  It is better to lose on performance
    a bit compared to Emacs GC hanging.
    
    The edge case is described in 
https://github.com/emacs-citar/citar/issues/397#issuecomment-1236226809
---
 lisp/org-element.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/org-element.el b/lisp/org-element.el
index cf46529ebd..f916647eec 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -7337,10 +7337,7 @@ the cache."
     (let ((mk (make-marker)))
       (set-marker mk to-pos)
       (setq to-pos mk)))
-  ;; Make sure that garbage collector does not stand on the way to
-  ;; maximum performance.
-  (let ((gc-cons-threshold #x40000000)
-        ;; Bind variables used inside loop to avoid memory
+  (let (;; Bind variables used inside loop to avoid memory
         ;; re-allocation on every iteration.
         ;; See https://emacsconf.org/2021/talks/faster/
         tmpnext-start tmpparent tmpelement)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]