emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/greader 4a178e8878 5/5: Merge branch 'devel'


From: ELPA Syncer
Subject: [elpa] externals/greader 4a178e8878 5/5: Merge branch 'devel'
Date: Sat, 3 Sep 2022 12:57:40 -0400 (EDT)

branch: externals/greader
commit 4a178e88787e0bf6f37653fe2d2666fd9e5b7b59
Merge: dc93b552d7 a1ecd535f8
Author: Michelangelo Rodriguez <michelangelo.rodriguez@gmail.com>
Commit: Michelangelo Rodriguez <michelangelo.rodriguez@gmail.com>

    Merge branch 'devel'
---
 greader.el | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/greader.el b/greader.el
index 164580290f..ff4d00e9f4 100644
--- a/greader.el
+++ b/greader.el
@@ -193,13 +193,6 @@ if set to t, when you call function `greader-read', that 
function sets a
     (define-key map (kbd "C-r f")   #'greader-get-attributes)
     (define-key map (kbd "C-r b")   #'greader-change-backend)
     map))
-
-(defvar greader-prefix-map
-  ;; FIXME: This var/keymap seems to be unused.
-  (let ((map (make-sparse-keymap)))
-    (define-key map (kbd "C-r") greader-mode-map)
-    map))
-
 (defvar greader-reading-map
   (let ((map (make-sparse-keymap)))
     (define-key map (kbd "SPC") #'greader-stop)
@@ -208,7 +201,6 @@ if set to t, when you call function `greader-read', that 
function sets a
     (define-key map (kbd "+")   #'greader-inc-rate)
     (define-key map (kbd "-")   #'greader-dec-rate)
     map))
-
 (defvar-local greader--reading nil
   "If non-nil, `greader-reading-map' is active.")
 
@@ -218,10 +210,14 @@ if set to t, when you call function `greader-read', that 
function sets a
   :lighter " greader"
   :group 'greader
   (cond
+   ;;; why we eval a call to a function?
+   ;;; I suppose because side-effect of enabling the mode.
+;;;   So we do wrong if evaluate greader-mode as a variable?
+   
    (greader-mode
     (add-to-list 'minor-mode-map-alist
                  `'(greader--reading . ,greader-reading-map))
-  (greader-load-backends))
+  (greader-load-backends))))
 ;;;code
 (defun greader-set-register ()
   "Set the `?G' register to the point in current buffer."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]