[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/vcomplete 5e055dc556 30/91: Fix cases where 'completion-in
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/vcomplete 5e055dc556 30/91: Fix cases where 'completion-in-region-mode' is used in the minibuffer |
Date: |
Tue, 24 May 2022 15:59:07 -0400 (EDT) |
branch: elpa/vcomplete
commit 5e055dc55665565e29f13a8e45986f194a41b2f2
Author: Daniel Semyonov <cmstr@dsemy.com>
Commit: Daniel Semyonov <cmstr@dsemy.com>
Fix cases where 'completion-in-region-mode' is used in the minibuffer
* vcomplete.el (vcomplete--setup-current): Check for
'completion-in-region' mode first to handle cases where it is used in
the minibuffer (interactive usage of 'eval-expression', for example)
correctly.
---
vcomplete.el | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/vcomplete.el b/vcomplete.el
index 7cd30f54d9..aceb649ca6 100644
--- a/vcomplete.el
+++ b/vcomplete.el
@@ -237,23 +237,23 @@ With prefix argument N, move N items (negative N means
move forward)."
(defun vcomplete--setup-current ()
"Setup ‘vcomplete-mode’ for the current buffer."
(vcomplete--reset-vars)
- (if (minibufferp)
+ (if-let ((map (assq #'completion-in-region-mode
+ minor-mode-overriding-map-alist)))
(progn
- (when (and vcomplete-auto-update minibuffer-completion-table)
+ (when vcomplete-auto-update
(add-hook 'pre-command-hook
- #'vcomplete--set-last-string-in-minibuffer nil t)
+ #'vcomplete--set-last-string-in-region nil t)
(add-hook 'post-command-hook
- #'vcomplete--update-in-minibuffer nil t))
- (use-local-map (make-composed-keymap vcomplete-command-map
- (current-local-map))))
- (when-let ((map (assq #'completion-in-region-mode
- minor-mode-overriding-map-alist)))
+ #'vcomplete--update-in-region nil t))
+ (setcdr map vcomplete-command-map))
+ (when minibuffer-completion-table
(when vcomplete-auto-update
(add-hook 'pre-command-hook
- #'vcomplete--set-last-string-in-region nil t)
+ #'vcomplete--set-last-string-in-minibuffer nil t)
(add-hook 'post-command-hook
- #'vcomplete--update-in-region nil t))
- (setcdr map vcomplete-command-map))))
+ #'vcomplete--update-in-minibuffer nil t))
+ (use-local-map (make-composed-keymap vcomplete-command-map
+ (current-local-map))))))
;;;###autoload
(define-minor-mode vcomplete-mode
- [nongnu] elpa/vcomplete 6684bd7640 41/91: ; Update info node to remove disclaimer for bug fixed in last commit, (continued)
- [nongnu] elpa/vcomplete 6684bd7640 41/91: ; Update info node to remove disclaimer for bug fixed in last commit, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete b14444ef8a 45/91: ; Edit docstrings to conform completely to 'checkdoc', ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 371e7c9b77 46/91: ; Add requirement for Embark to vcomplete-embark.el, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete d086a33a1a 49/91: * vcomplete.el (vcomplete-with-completions-buffer): Use 'derived-mode-p', ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 20e327acce 53/91: ; Indicate that Embark integration has been moved in the NEWS file, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 89fd222097 56/91: ; Improve docstring of 'vcomplete--disable-completion-in-region', ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 45adfdd13e 55/91: ; Document last commit in the NEWS file, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete a64c37e780 89/91: ; Generate 'vcomplete-pkg.el' automatically, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 7cd781f7f3 59/91: ; Documentation improvements, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 60b5a005bf 22/91: ; Add last few changes to NEWS file, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 5e055dc556 30/91: Fix cases where 'completion-in-region-mode' is used in the minibuffer,
ELPA Syncer <=
- [nongnu] elpa/vcomplete 21edba4beb 01/91: Initial commit, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete faca6e8c18 32/91: ; Change all instances of "‘" and "’" to "`" and "'" respectively, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete db010f4f61 34/91: Mark variables as risky local variables, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 5fefec3e91 40/91: Fix broken highlighting in completion list buffers when completing in-region, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 6136a3ba16 42/91: ; Update NEWS file, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 8ade381c7c 44/91: Move Embark integration to a separate file, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete b8402112ba 60/91: ; Remove unnecessary declaration, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete b30cedbf26 65/91: ; Fix small style issue in info file, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 8450b1befd 91/91: ; Bump to version 1.2.1, ELPA Syncer, 2022/05/24
- [nongnu] elpa/vcomplete 4019e76a3d 78/91: New internal function for getting the '*Completions*' window, ELPA Syncer, 2022/05/24