emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/pdf-tools 4460a4fd31 2/2: Add workaround for compilation u


From: ELPA Syncer
Subject: [nongnu] elpa/pdf-tools 4460a4fd31 2/2: Add workaround for compilation using C++17 standard library
Date: Mon, 9 May 2022 16:59:01 -0400 (EDT)

branch: elpa/pdf-tools
commit 4460a4fd3122e6b53cab1b7d86d6e19022d81fb1
Author: Vedang Manerikar <ved.manerikar@gmail.com>
Commit: Vedang Manerikar <ved.manerikar@gmail.com>

    Add workaround for compilation using C++17 standard library
    
    As explained in #102 by @Pi-Cla and @uliw, `pdf-tools` relies on
    private headers provided by `poppler`. In order to compile these
    correctly, we need the standard library provided by C++17.
    
    `pdf-tools` is built and tested against C++11. This workaround
    provides the correct CXXFLAGS to compile the library and fixes the
    immediate broken compilation problem.
    
    There should be two "correct" fixes to these:
    1. Remove dependence on private `poppler` headers. This is being
    tracked in #103 and #105
    2. Upgrade `pdf-tools` to build and run against new C++ versions. This
    is being tracked in #109.
    
    Closes: #70, #76, #102, #108, politza/pdf-tools#706.
---
 server/autobuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/autobuild b/server/autobuild
index 8b9c48230e..f9d25570fe 100755
--- a/server/autobuild
+++ b/server/autobuild
@@ -570,8 +570,8 @@ if [ -n "$INSTALL_DIR" ]; then
     prefix=--bindir=$INSTALL_DIR
 fi
 
-echo "./configure -q $prefix && make clean && make -s"
-eval "./configure -q $(quote "$prefix") && make clean && make -s || exit_fail"
+echo "./configure CXXFLAGS='-std=c++17' -q $prefix && make clean && make -s"
+eval "./configure CXXFLAGS='-std=c++17' -q $(quote "$prefix") && make clean && 
make -s || exit_fail"
 echo
 if [ -n "$INSTALL_DIR" ]; then
     echo "---------------------------"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]