[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/git-commit c3268fc69d 04/13: git-commit.el: Rearrange depe
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/git-commit c3268fc69d 04/13: git-commit.el: Rearrange dependencies |
Date: |
Fri, 6 May 2022 15:58:12 -0400 (EDT) |
branch: elpa/git-commit
commit c3268fc69d787371ca9689e6d5cafd675316eeb3
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
git-commit.el: Rearrange dependencies
Also state why we are going through all this trouble.
---
lisp/git-commit.el | 28 +++++++++++-----------------
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/lisp/git-commit.el b/lisp/git-commit.el
index 0df9ae0045..883f082e04 100644
--- a/lisp/git-commit.el
+++ b/lisp/git-commit.el
@@ -116,15 +116,10 @@
;; M-x customize-group RET git-commit RET
;;; Code:
-;;;; Dependencies
(require 'seq)
(require 'subr-x)
-(require 'magit-base nil t)
-(require 'magit-git nil t)
-(require 'magit-mode nil t)
-
(require 'log-edit)
(require 'ring)
(require 'rx)
@@ -132,23 +127,22 @@
(require 'transient)
(require 'with-editor)
-(defvar recentf-exclude)
-
-;;;; Declarations
+;; For historic reasons Magit isn't a hard dependency.
+(unless (and (require 'magit-base nil t)
+ (require 'magit-git nil t))
+ (declare-function magit-completing-read "magit-base"
+ ( prompt collection &optional predicate require-match
+ initial-input hist def fallback))
+ (declare-function magit-expand-git-file-name "magit-git" (filename))
+ (declare-function magit-git-lines "magit-git" (&rest args))
+ (declare-function magit-hook-custom-get "magit-base" (symbol))
+ (declare-function magit-list-local-branch-names "magit-git" ()))
(defvar diff-default-read-only)
(defvar flyspell-generic-check-word-predicate)
(defvar font-lock-beg)
(defvar font-lock-end)
-
-(declare-function magit-completing-read "magit-base"
- (prompt collection &optional predicate require-match
- initial-input hist def fallback))
-(declare-function magit-expand-git-file-name "magit-git" (filename))
-(declare-function magit-git-lines "magit-git" (&rest args))
-(declare-function magit-list-local-branch-names "magit-git" ())
-(declare-function magit-list-remote-branch-names "magit-git"
- (&optional remote relative))
+(defvar recentf-exclude)
;;; Options
;;;; Variables
- [nongnu] elpa/git-commit ec64fa4d63 06/13: magit-refresh: No longer hardcode magit-auto-revert-buffers, (continued)
- [nongnu] elpa/git-commit ec64fa4d63 06/13: magit-refresh: No longer hardcode magit-auto-revert-buffers, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit 2d679dff02 10/13: Move definition of magit-tramp-process-environment, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit e35f2b9be7 09/13: magit-blame.el: Move internal variables to beginning of file, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit 42a954adb4 03/13: Remove unnecessary variable declaration, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit ce29c373b9 08/13: magit-section.el: Move internal variables to beginning of file, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit 632536ca9c 07/13: Add magit-status-goto-initial-section to magit-create-buffer-hook, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit cc07643bb1 12/13: Use fboundp instead of declare-function for magit-blame functions, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit 6c98ba3dac 13/13: Use fboundp instead of requiring magit-wip, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit 16aa4340c8 02/13: Add missing section headings, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit 85e169736e 05/13: magit-refresh: No longer hardcode dedicated post-command hooks, ELPA Syncer, 2022/05/06
- [nongnu] elpa/git-commit c3268fc69d 04/13: git-commit.el: Rearrange dependencies,
ELPA Syncer <=
- [nongnu] elpa/git-commit f365aa48c4 11/13: Move shared infix argument magit:--gpg-sign to magit.el, ELPA Syncer, 2022/05/06