emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/consult 1aef7ceb3b: README: Prepare dropping consult-co


From: ELPA Syncer
Subject: [elpa] externals/consult 1aef7ceb3b: README: Prepare dropping consult-completing-read-multiple
Date: Tue, 3 May 2022 10:57:23 -0400 (EDT)

branch: externals/consult
commit 1aef7ceb3bab7bb6179529cd46684b3d55a022fa
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    README: Prepare dropping consult-completing-read-multiple
    
    Unfortunately it turned out that the consult-completing-read-multiple
    implementation is fundamentally flawed (See #567). It is also impossible to 
save
    the implementation since it was based on false assumptions. The assumption 
was
    that the completion tables passed to completing-read-multiple don't have
    non-trivial completion boundaries. For now I didn't remove the 
implementation
    from Consult yet since there are a few packages like Citar, which still 
rely on
    it. I will probably deprecate the command soon and remove it shortly after.
---
 README.org | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/README.org b/README.org
index 09e555afd0..499c2a6e63 100644
--- a/README.org
+++ b/README.org
@@ -346,7 +346,6 @@ their descriptions.
 #+findex: consult-apropos
 #+findex: consult-file-externally
 #+findex: consult-completion-in-region
-#+findex: consult-completing-read-multiple
 #+findex: consult-theme
 #+findex: consult-man
 #+findex: consult-preview-at-point
@@ -388,10 +387,6 @@ their descriptions.
   minibuffer, the server does not receive the updated input. LSP completion
   works with Corfu or Company though, which perform the completion directly in
   the original buffer.
-- =consult-completing-read-multiple=: Enhanced drop-in replacement for
-  =completing-read-multiple= which works better for long candidates. You can
-  select/deselect multiple candidates by pressing ~RET~. Afterwards the 
selections
-  are confirmed by pressing ~RET~ again.
 
 * Special features
 :properties:
@@ -827,9 +822,6 @@ configuration examples.
     ;; This adds thin lines, sorting and hides the mode line of the window.
     (advice-add #'register-preview :override #'consult-register-window)
 
-    ;; Optionally replace `completing-read-multiple' with an enhanced version.
-    (advice-add #'completing-read-multiple :override 
#'consult-completing-read-multiple)
-
     ;; Use Consult to select xref locations with preview
     (setq xref-show-xrefs-function #'consult-xref
           xref-show-definitions-function #'consult-xref)
@@ -900,7 +892,6 @@ an overview of all Consult variables and functions with 
their descriptions.
 | consult-bookmark-narrow          | Narrowing configuration for 
=consult-bookmark=          |
 | consult-buffer-filter            | Filter for =consult-buffer=               
              |
 | consult-buffer-sources           | List of virtual buffer sources            
            |
-| consult-crm-prefix               | Prefix string for CRM candidates          
            |
 | consult-find-args                | Command line arguments for find           
            |
 | consult-fontify-max-size         | Buffers larger than this limit are not 
fontified      |
 | consult-fontify-preserve         | Preserve fontification for line-based 
commands.       |



reply via email to

[Prev in Thread] Current Thread [Next in Thread]