emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/embark e6a991c322 5/9: Let's not be embarrased about ad


From: ELPA Syncer
Subject: [elpa] externals/embark e6a991c322 5/9: Let's not be embarrased about advising an internal Embark function
Date: Mon, 2 May 2022 09:57:32 -0400 (EDT)

branch: externals/embark
commit e6a991c32215e538bd2778f662c63d8fa58245cc
Author: Omar Antolín <omar.antolin@gmail.com>
Commit: Omar Antolín <omar.antolin@gmail.com>

    Let's not be embarrased about advising an internal Embark function
---
 embark-consult.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/embark-consult.el b/embark-consult.el
index 898cde0281..72cb479f1a 100644
--- a/embark-consult.el
+++ b/embark-consult.el
@@ -395,8 +395,6 @@ Meant as :after-until advice for 
`embark-collect--metadatum'."
          (transform cand)
          (type (car (alist-get type config))))))))
 
-;; TODO can we find a better solution than the advice here?
-;; Can we hook more directly into `embark-collect--metadatum'?
 (advice-add #'embark-collect--metadatum :after-until
             #'embark-consult--imenu-group-function)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]