emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 71de86e8ea 17/19: Fix invoking the suffix the


From: Jonas Bernoulli
Subject: [elpa] externals/transient 71de86e8ea 17/19: Fix invoking the suffix the cursor is on in the transient buffer
Date: Mon, 2 May 2022 05:08:26 -0400 (EDT)

branch: externals/transient
commit 71de86e8eae4b8eb972356b924a2fc4273559165
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Fix invoking the suffix the cursor is on in the transient buffer
    
    In [1: bb056e71] we changed how suffix commands are invoked when a
    button is activated because the old way resulted in the transient
    buffer being current when the suffix command is invoked, which messes
    things up.
    
    Clicking on a button in the transient buffer now only temporarily
    makes the transient buffer current.  Other bindings had to be moved
    from `transient-button-map' to `transient-popup-navigation'.  The
    binding for invoking the suffix "under the cursor" was overlooked.
    
    Closes #197.
    
    1: 2022-03-25 bb056e7156b3d88f42770ec55e1a7447a95aca96
       Invoke suffix commands directly when a button is pushed
---
 lisp/transient.el | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index 6213ccebaf..926806eae4 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -143,15 +143,15 @@ bindings are available:
 \\<transient-popup-navigation-map>\
 - \\[transient-backward-button] moves the cursor to the previous suffix.
 - \\[transient-forward-button] moves the cursor to the next suffix.
-\\<transient-button-map>\
 - \\[transient-push-button] invokes the suffix the cursor is on.
+\\<transient-button-map>\
 - \\`<mouse-1>' and \\`<mouse-2>' invoke the clicked on suffix.
 \\<transient-popup-navigation-map>\
 - \\[transient-isearch-backward]\
- and \\[transient-isearch-forward] start isearch in the popup buffer.
+ and \\[transient-isearch-forward] starts isearch in the popup buffer.
 
-Each of these bindings is defined in either `transient-button-map'
-or `transient-popup-navigation-map'."
+\\`<mouse-1>' and \\`<mouse-2>' are bound in `transient-push-button'.
+All other bindings are in `transient-popup-navigation-map'."
   :package-version '(transient . "0.4.0")
   :group 'transient
   :type 'boolean)
@@ -1588,14 +1588,18 @@ to `transient-predicate-map'.  Also see 
`transient-base-map'.")
     (define-key map (kbd "<down>") #'transient-forward-button)
     (define-key map (kbd "C-r")    #'transient-isearch-backward)
     (define-key map (kbd "C-s")    #'transient-isearch-forward)
-    map))
+    (define-key map (kbd "RET")    #'transient-push-button)
+    map)
+  "One of the keymaps used when popup navigation is enabled.
+See `transient-enable-popup-navigation'.")
 
 (defvar transient-button-map
   (let ((map (make-sparse-keymap)))
     (define-key map (kbd "<mouse-1>") #'transient-push-button)
     (define-key map (kbd "<mouse-2>") #'transient-push-button)
-    (define-key map (kbd "RET")       #'transient-push-button)
-    map))
+    map)
+  "One of the keymaps used when popup navigation is enabled.
+See `transient-enable-popup-navigation'.")
 
 (defvar transient-predicate-map
   (let ((map (make-sparse-keymap)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]