emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/pdf-tools 91afc4f87b 2/3: Use `l` and `r` for backward / f


From: ELPA Syncer
Subject: [nongnu] elpa/pdf-tools 91afc4f87b 2/3: Use `l` and `r` for backward / forward in history.
Date: Fri, 31 Dec 2021 03:58:41 -0500 (EST)

branch: elpa/pdf-tools
commit 91afc4f87baa39347c033d850b29d36d277e0d69
Author: Vedang Manerikar <ved.manerikar@gmail.com>
Commit: Vedang Manerikar <ved.manerikar@gmail.com>

    Use `l` and `r` for backward / forward in history.
    
    `l` and `r` are the conventional bindings for history navigation.
    
    The previous key-bindings `B` and `N` are kept as-is for people who
    were used to it.
    
    This is a breaking change because `r` was previously bound to
    `revert-buffer`. However, `g` is also bound to `revert-buffer` and is
    the conventional binding for `revert` so this should be okay.
    
    Fixes: #43
---
 README.org          | 2 +-
 lisp/pdf-history.el | 2 ++
 lisp/pdf-view.el    | 1 -
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/README.org b/README.org
index c05171b161..8e6adfed7b 100644
--- a/README.org
+++ b/README.org
@@ -366,7 +366,7 @@ PDFView Mode is an Emacs PDF viewer. It displays PDF files 
as PNG images in Emac
 | Jump to Occur Line                            | ~RETURN~              |
 | Pick a Link and Jump                          | ~F~                   |
 | Incremental Search in Links                   | ~f~                   |
-| History Back / Forwards                       | ~B~ / ~N~             |
+| History Back / Forwards                       | ~l~ / ~r~             |
 | Display Outline                               | ~o~                   |
 | Jump to Section from Outline                  | ~RETURN~              |
 | Jump to Page                                  | ~M-g g~               |
diff --git a/lisp/pdf-history.el b/lisp/pdf-history.el
index 2d02d685e6..e380cf5530 100644
--- a/lisp/pdf-history.el
+++ b/lisp/pdf-history.el
@@ -40,6 +40,8 @@
   (let ((kmap (make-sparse-keymap)))
     (define-key kmap (kbd "B") #'pdf-history-backward)
     (define-key kmap (kbd "N") #'pdf-history-forward)
+    (define-key kmap (kbd "l") #'pdf-history-backward)
+    (define-key kmap (kbd "r") #'pdf-history-forward)
     kmap)
   "Keymap used in `pdf-history-minor-mode'.")
 
diff --git a/lisp/pdf-view.el b/lisp/pdf-view.el
index 87a03a951c..70c2ee48dd 100644
--- a/lisp/pdf-view.el
+++ b/lisp/pdf-view.el
@@ -284,7 +284,6 @@ regarding display of the region in the later function.")
     ;; Reconvert
     (define-key map (kbd "C-c C-c")   'doc-view-mode)
     (define-key map (kbd "g")         'revert-buffer)
-    (define-key map (kbd "r")         'revert-buffer)
     ;; Region
     (define-key map [down-mouse-1] 'pdf-view-mouse-set-region)
     (define-key map [M-down-mouse-1] 'pdf-view-mouse-set-region-rectangle)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]