emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/mct 1b2d5cc25b: Remove task for mct-choose-completion-n


From: ELPA Syncer
Subject: [elpa] externals/mct 1b2d5cc25b: Remove task for mct-choose-completion-number
Date: Fri, 31 Dec 2021 03:57:34 -0500 (EST)

branch: externals/mct
commit 1b2d5cc25b39b8c8a32094b3f1a2ad9d9e36e9e3
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Remove task for mct-choose-completion-number
    
    We cannot make it work in its current state for mct-region-mode.  The
    reason is that as soon as the minibuffer is activated to select a line
    number, the Completions' window gets removed if the point was not
    already inside of it (so if it was in the buffer that started
    completion-in-region).
    
    I tried various functions to make the window dedicated, in the hope that
    it would remain on display, but none worked.  Perhaps I did something
    wrong though, so if someone has a better idea, I am happy to learn about
    it.
---
 mct.el | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mct.el b/mct.el
index f4cf4fe00e..db17f61916 100644
--- a/mct.el
+++ b/mct.el
@@ -1199,9 +1199,6 @@ minibuffer)."
 
 (defvar mct-region-completion-list-map
   (let ((map (make-sparse-keymap)))
-    ;; TODO 2021-12-29: Maybe we can make this work in this context as
-    ;; well.
-    ;; (define-key map [remap goto-line] #'mct-choose-completion-number)
     (define-key map [remap next-line] #'mct-next-completion-or-quit)
     (define-key map [remap previous-line] #'mct-previous-completion-or-quit)
     (define-key map (kbd "n") #'mct-next-completion-or-quit)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]