emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/mct 90d07f5d3e 47/64: Remove mct--completions-choose-co


From: ELPA Syncer
Subject: [elpa] externals/mct 90d07f5d3e 47/64: Remove mct--completions-choose-completion
Date: Thu, 30 Dec 2021 23:57:59 -0500 (EST)

branch: externals/mct
commit 90d07f5d3e456198063cbc178079e5436d0ec035
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Remove mct--completions-choose-completion
---
 mct.el | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/mct.el b/mct.el
index cb5fa017d6..08b43b93aa 100644
--- a/mct.el
+++ b/mct.el
@@ -692,26 +692,26 @@ If ARG is supplied, move that many completion groups at a 
time."
 
 ;;;;; Candidate selection
 
-(defun mct--completions-choose-completion ()
-  "Choose candidate from the Completions' buffer."
-  (when-let* ((window (mct--get-completion-window))
-              (buffer (window-buffer)))
-    (with-current-buffer buffer
-      (choose-completion))))
-
+;; TODO review, is this not almost the same as choose-completion?
 (defun mct-choose-completion-exit ()
   "Run `choose-completion' in the Completions buffer and exit."
   (interactive nil mct-mode)
   (when (active-minibuffer-window)
-    (mct--completions-choose-completion)
+    (when-let* ((window (mct--get-completion-window))
+              (buffer (window-buffer)))
+    ;; TODO review, are we not always in the *Completions* buffer here?
+    (with-current-buffer buffer
+      (choose-completion)))
     (minibuffer-force-complete-and-exit)))
 
+;; TODO review, is this not almost the same as choose-completion?
 (defun mct-choose-completion-no-exit ()
   "Run `choose-completion' in the Completions without exiting."
   (interactive nil mct-mode)
   (when-let* ((window (mct--get-completion-window))
               (buffer (window-buffer))
               (mini (active-minibuffer-window)))
+    ;; TODO review, are we not always in the *Completions* buffer here?
     (with-current-buffer buffer
       (let ((completion-no-auto-exit t))
         (choose-completion)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]