[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/blist c868a2d8b3 24/31: * blist.el (blist-all-bookmarks
From: |
ELPA Syncer |
Subject: |
[elpa] externals/blist c868a2d8b3 24/31: * blist.el (blist-all-bookmarks): refactor |
Date: |
Tue, 28 Dec 2021 16:57:41 -0500 (EST) |
branch: externals/blist
commit c868a2d8b335f344d71ac26909741eb9fb02ae0f
Author: JSDurand <mmemmew@gmail.com>
Commit: JSDurand <mmemmew@gmail.com>
* blist.el (blist-all-bookmarks): refactor
Now we don't need to toggle the hidden groups to map through those
lines, since they are not actually deleted from the buffer, and we can
simply map through them as usual.
---
blist.el | 26 ++++----------------------
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/blist.el b/blist.el
index d583de5cbd..1dcd922cab 100644
--- a/blist.el
+++ b/blist.el
@@ -332,6 +332,9 @@ of the required type."
(defalias #'blist #'blist-list-bookmarks)
+;; REVIEW: Is it a good idea to preserve the hidden status of groups?
+;; REVIEW: Use the header?
+
;;;###autoload
(defun blist-list-bookmarks (&rest _args)
"List bookmarks in an ibuffer fashion.
@@ -1271,28 +1274,7 @@ get unique numeric suffixes \"<2>\", \"<3>\", etc."
(defun blist-all-bookmarks ()
"Return the list of all bookmark indices, even the hidden ones."
- (append
- ;; normal lines
- (ilist-map-lines #'ilist-get-index #'ilist-get-index)
- ;; hidden lines
- (apply
- #'append
- (ilist-map-lines
- (lambda ()
- (blist-toggle-group)
- (let ((start (point))
- (end (save-excursion
- (ilist-forward-group-header 1)
- (point)))
- temp)
- (setq
- temp
- (ilist-map-lines #'ilist-get-index #'ilist-get-index
- start end))
- (blist-toggle-group)
- temp))
- (lambda ()
- (get-text-property (point) 'blist-hidden-text))))))
+ (ilist-map-lines #'ilist-get-index #'ilist-get-index nil nil t))
;;;; Jumping around
- [elpa] branch externals/blist created (now e7d56657eb), ELPA Syncer, 2021/12/28
- [elpa] externals/blist 97a8b93b12 01/31: initial working version, ELPA Syncer, 2021/12/28
- [elpa] externals/blist 896e5568f8 04/31: More features, ELPA Syncer, 2021/12/28
- [elpa] externals/blist a4c0a7626f 07/31: fix defcustom problem, ELPA Syncer, 2021/12/28
- [elpa] externals/blist fa54e09b57 03/31: More features, ELPA Syncer, 2021/12/28
- [elpa] externals/blist a24f9d6d35 06/31: fix `blist-select', ELPA Syncer, 2021/12/28
- [elpa] externals/blist a0b9bc4eb5 18/31: * blist.el (blist-relocate): Fix a bug caused by a typo., ELPA Syncer, 2021/12/28
- [elpa] externals/blist 950a214456 28/31: New option: blist-use-header-p, ELPA Syncer, 2021/12/28
- [elpa] externals/blist 4a5eb414f7 27/31: Fix errors and byte-compile, ELPA Syncer, 2021/12/28
- [elpa] externals/blist db67745821 13/31: Fix some README issues, ELPA Syncer, 2021/12/28
- [elpa] externals/blist c868a2d8b3 24/31: * blist.el (blist-all-bookmarks): refactor,
ELPA Syncer <=
- [elpa] externals/blist eddd17ce4d 14/31: try to fix image, ELPA Syncer, 2021/12/28
- [elpa] externals/blist 4a4d94c09d 20/31: blist.el: QoL refinements, ELPA Syncer, 2021/12/28
- [elpa] externals/blist c2f4bc47d4 25/31: fix previous bugs caused by invisibility, ELPA Syncer, 2021/12/28
- [elpa] externals/blist f1b556af33 12/31: Add README, ELPA Syncer, 2021/12/28
- [elpa] externals/blist 48510bdefa 05/31: preserve the original point in building the list, ELPA Syncer, 2021/12/28
- [elpa] externals/blist 41735b2a03 08/31: Make `blist-list-bookmarks' interactive, ELPA Syncer, 2021/12/28
- [elpa] externals/blist 1bac76696c 09/31: fix a wrong function call, ELPA Syncer, 2021/12/28
- [elpa] externals/blist c5145aea0e 02/31: Fix documentations., ELPA Syncer, 2021/12/28
- [elpa] externals/blist 0f0ceddf53 26/31: Refine the ChangeLog., ELPA Syncer, 2021/12/28
- [elpa] externals/blist 81d5a0fe71 19/31: blist: refine functions to display annotations, ELPA Syncer, 2021/12/28