emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/blist c868a2d8b3 24/31: * blist.el (blist-all-bookmarks


From: ELPA Syncer
Subject: [elpa] externals/blist c868a2d8b3 24/31: * blist.el (blist-all-bookmarks): refactor
Date: Tue, 28 Dec 2021 16:57:41 -0500 (EST)

branch: externals/blist
commit c868a2d8b335f344d71ac26909741eb9fb02ae0f
Author: JSDurand <mmemmew@gmail.com>
Commit: JSDurand <mmemmew@gmail.com>

    * blist.el (blist-all-bookmarks): refactor
    
    Now we don't need to toggle the hidden groups to map through those
    lines, since they are not actually deleted from the buffer, and we can
    simply map through them as usual.
---
 blist.el | 26 ++++----------------------
 1 file changed, 4 insertions(+), 22 deletions(-)

diff --git a/blist.el b/blist.el
index d583de5cbd..1dcd922cab 100644
--- a/blist.el
+++ b/blist.el
@@ -332,6 +332,9 @@ of the required type."
 
 (defalias #'blist #'blist-list-bookmarks)
 
+;; REVIEW: Is it a good idea to preserve the hidden status of groups?
+;; REVIEW: Use the header?
+
 ;;;###autoload
 (defun blist-list-bookmarks (&rest _args)
   "List bookmarks in an ibuffer fashion.
@@ -1271,28 +1274,7 @@ get unique numeric suffixes \"<2>\", \"<3>\", etc."
 
 (defun blist-all-bookmarks ()
   "Return the list of all bookmark indices, even the hidden ones."
-  (append
-   ;; normal lines
-   (ilist-map-lines #'ilist-get-index #'ilist-get-index)
-   ;; hidden lines
-   (apply
-    #'append
-    (ilist-map-lines
-     (lambda ()
-       (blist-toggle-group)
-       (let ((start (point))
-             (end (save-excursion
-                    (ilist-forward-group-header 1)
-                    (point)))
-             temp)
-         (setq
-          temp
-          (ilist-map-lines #'ilist-get-index #'ilist-get-index
-                           start end))
-         (blist-toggle-group)
-         temp))
-     (lambda ()
-       (get-text-property (point) 'blist-hidden-text))))))
+  (ilist-map-lines #'ilist-get-index #'ilist-get-index nil nil t))
 
 ;;;; Jumping around
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]