[nongnu] elpa/popup 2cd8b9a703 3/3: Merge pull request #129 from tumashu/master

[ELPA Syncer]

branch: elpa/popup
commit 2cd8b9a703e9b400fef73abf66f6d46f3fb2e932
Merge: 5b2caec22c e597c1987c
Author: Jen-Chieh Shen <jcs090218@gmail.com>
Commit: GitHub <noreply@github.com>

    Merge pull request #129 from tumashu/master
    
    Some improve about popup-el.
---
 popup.el | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/popup.el b/popup.el
index 4035ae530d..af7c9fcba9 100644
--- a/popup.el
+++ b/popup.el
@@ -242,14 +242,16 @@ ITEM is not string."
 (defun popup-replace-displayable (str &optional rep)
   "Replace non-displayable character from STR.
 
-Optional argument REP is the replacement string of non-displayable character."
+Optional argument REP is the replacement string of
+non-displayable character."
   (unless rep (setq rep ""))
   (let ((result ""))
-    (mapc (lambda (ch)
-            (setq result (concat result
-                                 (if (char-displayable-p ch) (string ch)
-                                   rep))))
-          str)
+    (dolist (string (split-string str ""))
+      (let* ((char (string-to-char string))
+             (string (if (char-displayable-p char)
+                         string
+                       rep)))
+        (setq result (concat result string))))
     result))
 
 (cl-defun popup-make-item (name
@@ -1051,6 +1053,7 @@ HELP-DELAY is a delay of displaying helps."
                      nostrip
                      prompt
                      face
+                     &allow-other-keys
                      &aux tip lines)
   "Show a tooltip of STRING at POINT. This function is
 synchronized unless NOWAIT specified. Almost all arguments are