[nongnu] elpa/webpaste 533bb40 290/298: Apply suggestions from code review

[ELPA Syncer]

branch: elpa/webpaste
commit 533bb406c4d68bf94476ce8800fd3c4913837aaa
Author: Dale Sedivec <dale+github@codefu.org>
Commit: Dale Sedivec <dale@codefu.org>

    Apply suggestions from code review
    
    Co-authored-by: Elis Hirwing <elis@hirwing.se>
---
 README.org  |  2 +-
 webpaste.el | 33 +++++++++++++++++++--------------
 2 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/README.org b/README.org
index c7e5240..d0a10f8 100644
--- a/README.org
+++ b/README.org
@@ -198,9 +198,9 @@ webpaste first and then just read the documentation by 
running this:
  - [X] gist.github.com
  - [X] paste.pound-python.org
  - [X] paste.mozilla.org
+ - [X] bpa.st
  - [ ] paste.debian.net
  - [ ] bpaste.net
  - [ ] eval.in
- - [X] bpa.st
  - [ ] ptpb.pw (RIP due to 
[[https://github.com/ptpb/pb/issues/245][ptpb/pb#245]] & 
[[https://github.com/ptpb/pb/issues/240][ptpb/pb#240]])
  - [ ] sprunge.us (removed due to 
[[https://github.com/rupa/sprunge/issues/45][sprunge#45]] that yields 500s)
diff --git a/webpaste.el b/webpaste.el
index 204dc26..fb2e404 100644
--- a/webpaste.el
+++ b/webpaste.el
@@ -160,9 +160,9 @@ This uses `browse-url-generic' to open URLs."
     ("bpa.st"
      :uri "https://bpa.st/api/v1/paste";
      :post-data (("expiry" . "1day"))
-     :post-field-lambda (lambda () #'webpaste--providers-pinnwand-request)
+     :post-field-lambda webpaste--providers-pinnwand-request
      :lang-overrides ((emacs-lisp-mode . "emacs"))
-     :success-lambda (lambda () #'webpaste--providers-pinnwand-success)))
+     :success-lambda webpaste--providers-pinnwand-success))
 
   "Define all webpaste.el providers.
 Consists of provider name and arguments to be sent to `webpaste--provider' when
@@ -307,20 +307,25 @@ This is the default failover hook that we use for most 
providers."
                    ;; Otherwise we return the formatted post data
                    post-data))))
 
-(cl-defun webpaste--providers-pinnwand-request (&key text post-data 
provider-uri
-                                                  &allow-other-keys)
+(cl-defun webpaste--providers-pinnwand-request ()
   "Build request for pinnwand pastebins."
-  (let* ((lexer (or (webpaste--get-buffer-language provider-uri) "text"))
-         (file `(("lexer" . ,lexer) ("content" . ,text)))
-         (file-name (buffer-file-name)))
-    (when file-name
-      (push (cons "name" (file-name-nondirectory file-name)) file))
-    (json-encode `((expiry . ,(or (cdr (assoc "expiry" post-data)) "1day"))
-                   (files . ,(vector file))))))
-
-(cl-defun webpaste--providers-pinnwand-success (&key data &allow-other-keys)
+  (cl-function (lambda (&key text post-data provider-uri &allow-other-keys)
+                 "Build request for pinnwand pastebins."
+                 (let* ((lexer (or (webpaste--get-buffer-language 
provider-uri) "text"))
+                        (file `(("lexer" . ,lexer) ("content" . ,text)))
+                        (file-name (buffer-file-name)))
+                   (when file-name
+                     (push (cons "name"
+                                 (file-name-nondirectory file-name))
+                           file))
+                   (json-encode `((expiry . ,(or (cdr (assoc "expiry" 
post-data)) "1day"))
+                                  (files . ,(vector file))))))))
+
+
+(cl-defun webpaste--providers-pinnwand-success ()
   "Parse JSON response from pinnwand pastebins in DATA."
-  (webpaste--return-url (cdr (assq 'link (json-read-from-string data)))))
+  (cl-function (lambda (&key data &allow-other-keys)
+                 (webpaste--return-url (cdr (assq 'link (json-read-from-string 
data)))))))