[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/webpaste 7b84568 155/298: Avoid setq's in favor of let
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/webpaste 7b84568 155/298: Avoid setq's in favor of let |
Date: |
Thu, 9 Dec 2021 19:00:04 -0500 (EST) |
branch: elpa/webpaste
commit 7b84568217c7ae884ca4eb3d5d610b691a48bf09
Author: Elis Axelsson <elis.axelsson@gmail.com>
Commit: Elis Axelsson <elis.axelsson@gmail.com>
Avoid setq's in favor of let
---
test/webpaste-test.el | 46 +++++++++++++++++++---------------------------
1 file changed, 19 insertions(+), 27 deletions(-)
diff --git a/test/webpaste-test.el b/test/webpaste-test.el
index bf49352..0a46445 100644
--- a/test/webpaste-test.el
+++ b/test/webpaste-test.el
@@ -117,27 +117,21 @@
(ert-deftest webpaste-test/get-provider-priority ()
"Test how it populates webpaste/get-provider-priority."
- ;;; Test autopopulation of list based on providers avaliable
- ;; Prepare variables
- (setq-default webpaste-provider-priority nil)
- (setq-default webpaste-providers-alist
- `(("provider1" "lambda")
- ("provider2" "lambda")
- ("provider3" "lambda")))
-
- ;; Do test
- (should (equal (webpaste/get-provider-priority)
- '("provider1" "provider2" "provider3")))
+ ;; Test autopopulation of list based on providers avaliable
+ (let ((webpaste-provider-priority nil)
+ (webpaste-providers-alist '(("provider1" . "lambda")
+ ("provider2" . "lambda")
+ ("provider3" . "lambda"))))
+ ;; Do test
+ (should (equal (webpaste/get-provider-priority)
+ '("provider1" "provider2" "provider3"))))
;;; Test static population of provider priority
- ;; Prepare variables
- (setq-default webpaste-provider-priority
- '("provider2" "provider1" "provider3"))
- (setq-default webpaste-providers-alist '())
-
- ;; Do test
- (should (equal (webpaste/get-provider-priority)
- '("provider2" "provider1" "provider3"))))
+ (let ((webpaste-provider-priority '("provider2" "provider1" "provider3"))
+ (webpaste-providers-alist nil))
+ ;; Do test
+ (should (equal (webpaste/get-provider-priority)
+ '("provider2" "provider1" "provider3")))))
@@ -145,10 +139,9 @@
"This test just sends a message to a good provider that just works."
;; Temporal storage for result
- (let ((returned-result nil))
- ;; Reset all webpaste variables
- (setq-default webpaste-tested-providers nil)
- (setq-default webpaste-provider-priority nil)
+ (let ((returned-result nil)
+ (webpaste-tested-providers nil)
+ (webpaste-provider-priority nil))
;; Make a fake provider that just "returns" the paste result by setting a
;; variable and concatinate it with "Works: " so we can see it showing up
@@ -173,10 +166,9 @@ Then the bad provider pastes again like it should and we
check that we got the
result from the good provider only."
;; Temporal storage for result
- (let ((returned-result nil))
- ;; Reset all webpaste variables
- (setq-default webpaste-tested-providers nil)
- (setq-default webpaste-provider-priority nil)
+ (let ((returned-result nil)
+ (webpaste-tested-providers nil)
+ (webpaste-provider-priority nil))
;; Creates a "broken" provider that will call on the next provider due to a
;; faked failure and checks that the next provider is picked up correctly.
- [nongnu] elpa/webpaste b7acc4e 100/298: Added test for returning of URL's, (continued)
- [nongnu] elpa/webpaste b7acc4e 100/298: Added test for returning of URL's, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 8027e6e 106/298: Run tests on emacs 25.2 since it's been released, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste e04d885 114/298: Add (prog1 nil ...) form to avoid having the nil hanging at the end, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 124ef8b 119/298: Drop usage of concat when returning link to users message field, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 69166a3 121/298: Moved error-handling of failed requests out so providers must specify it, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 69f9452 122/298: Bump version for minor release, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 8905a52 125/298: Re-arrange arguments to webpaste-provider and update docs, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 72ba31e 127/298: Bump version for new release, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 7d03ed3 137/298: Removed unused variables defined in function declaration, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 07a85e9 142/298: Added pre-calculated alist of languages for providers, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 7b84568 155/298: Avoid setq's in favor of let,
ELPA Syncer <=
- [nongnu] elpa/webpaste 0c0e88a 079/298: Added basic structure of tests file, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 95289e5 082/298: Added .travis.yml config file, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 7c90bc5 090/298: Merge branch 'tarsius-master', ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste ec85d7d 092/298: Added unit test for static provider configuration, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 2c5eb3c 149/298: Fix broken build., ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste f161620 163/298: Refactored the success callbacks, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste dab97dd 130/298: Make post-fields-lambda take named parameters, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste f83fd7b 145/298: Added note about new provider to implement. This refs #7, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 62e0f33 165/298: Refactor default post field lambda, ELPA Syncer, 2021/12/09
- [nongnu] elpa/webpaste 6e116ea 166/298: Merge branch 'refactor-away-defvars', ELPA Syncer, 2021/12/09