[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/subed 3b4b56a 384/389: Merge pull request #49 from sachac/
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/subed 3b4b56a 384/389: Merge pull request #49 from sachac/fix-vtt-spaces |
Date: |
Fri, 3 Dec 2021 11:01:03 -0500 (EST) |
branch: elpa/subed
commit 3b4b56ab45549e86b1fb9d1f954335530bcf5c2c
Merge: bf3e832 b6e08c2
Author: Sacha Chua <sacha@sachachua.com>
Commit: GitHub <noreply@github.com>
Merge pull request #49 from sachac/fix-vtt-spaces
Handle spaces in between VTT subtitles
---
subed/subed-vtt.el | 2 +-
tests/test-subed-vtt.el | 9 +++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/subed/subed-vtt.el b/subed/subed-vtt.el
index f0fd28f..1531e47 100644
--- a/subed/subed-vtt.el
+++ b/subed/subed-vtt.el
@@ -232,7 +232,7 @@ can be found."
;; `subed-vtt--regexp-separator' here because if subtitle text is empty,
;; it may be the only empty line in the separator, i.e. there's only one
;; "\n".
- (let ((regex (concat "\\([[:blank:]]*\n+" subed-vtt--regexp-timestamp
"\\|\\([[:blank:]]*\n*\\)\\'\\)")))
+ (let ((regex (concat "\\([[:blank:]]*\n\\)+\\("
subed-vtt--regexp-timestamp "\\)\\|\\([[:blank:]]*\n*\\)\\'")))
(when (re-search-forward regex nil t)
(goto-char (match-beginning 0))))
(unless (= (point) orig-point)
diff --git a/tests/test-subed-vtt.el b/tests/test-subed-vtt.el
index 04c244c..f1ff487 100644
--- a/tests/test-subed-vtt.el
+++ b/tests/test-subed-vtt.el
@@ -260,6 +260,15 @@ Baz.
(backward-char 2)
(expect (subed-vtt--jump-to-subtitle-end) :to-be 112)
(expect (looking-back "^Baz.$") :to-be t)))
+ (it "handles spaces in between subtitles."
+ (with-temp-vtt-buffer
+ (insert mock-vtt-data)
+ (goto-char (point-min))
+ (re-search-forward "Foo\\.\n")
+ (replace-match "Foo.\n ")
+ (goto-char (point-min))
+ (expect (subed-vtt--jump-to-subtitle-end) :to-be 43)
+ (expect (looking-back "^Foo.$") :to-be t)))
(it "returns nil if subtitle end cannot be found."
(with-temp-vtt-buffer
(expect (subed-vtt--jump-to-subtitle-end) :to-be nil)))
- [nongnu] elpa/subed beda7dc 371/389: Add functions to insert HTML-like tags, (continued)
- [nongnu] elpa/subed beda7dc 371/389: Add functions to insert HTML-like tags, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed c23dd84 373/389: Add info about the new features to README.org, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 6a5802c 374/389: Add video movement per frame, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 828764f 375/389: Change keybindings and use a transient keymap, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 5de6f21 377/389: Add msecs-to-timestamp as a common function, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed b42f563 378/389: Add audio extensions, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 6b1a6f2 367/389: Add computing and displaying characters per second, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 3ba295b 336/389: Fix "service name too long", ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 961e5eb 343/389: More subed-vtt fixes: require subed-vtt, validate better, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 87b3823 353/389: subed-split-subtitle works at the beginning or end of subtitle text, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 3b4b56a 384/389: Merge pull request #49 from sachac/fix-vtt-spaces,
ELPA Syncer <=
- [nongnu] elpa/subed bee9e63 342/389: subed-vtt: Fix syncing point with player, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 016c6a5 363/389: subed-split-subtitle: Handle more cases, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 6164f88 380/389: Keep track of video being played, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 70561f0 381/389: Make hours optional in VTT files, following the spec, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed bf3e832 382/389: Check if subed--cps-overlay exists before trying to update it, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed b6e08c2 383/389: Handle spaces in between VTT subtitles, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 564b6fe 386/389: Add preliminary support for comments in VTT files, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d5751c5 334/389: Change default faces to inherit color values, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 65ed21c 350/389: Add tests/test-subed-vtt.el, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 6eba992 376/389: Add ability to proportionally scale subtitles., ELPA Syncer, 2021/12/03