emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/subed d1b308e 280/389: Make subed-subtitle-time-adjusted-h


From: ELPA Syncer
Subject: [nongnu] elpa/subed d1b308e 280/389: Make subed-subtitle-time-adjusted-hook buffer-local
Date: Fri, 3 Dec 2021 11:00:41 -0500 (EST)

branch: elpa/subed
commit d1b308e2914ea5e1b7516cd4e85b510c4c126d43
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>

    Make subed-subtitle-time-adjusted-hook buffer-local
---
 subed/subed-config.el      | 2 +-
 tests/test-subed-common.el | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/subed/subed-config.el b/subed/subed-config.el
index 57af80b..8c7c34c 100644
--- a/subed/subed-config.el
+++ b/subed/subed-config.el
@@ -229,7 +229,7 @@ hardcoded."
 
 ;; Hooks
 
-(defvar subed-subtitle-time-adjusted-hook ()
+(defvar-local subed-subtitle-time-adjusted-hook ()
   "Functions to call when a subtitle's start or stop time has changed.
 The functions are called with the subtitle's start time.")
 
diff --git a/tests/test-subed-common.el b/tests/test-subed-common.el
index bea81d4..cff02fb 100644
--- a/tests/test-subed-common.el
+++ b/tests/test-subed-common.el
@@ -165,8 +165,8 @@ Baz.
   (it "runs the appropriate hook."
     (let ((foo (setf (symbol-function 'foo) (lambda (msecs) ()))))
       (spy-on 'foo)
-      (add-hook 'subed-subtitle-time-adjusted-hook 'foo)
       (with-temp-srt-buffer
+        (add-hook 'subed-subtitle-time-adjusted-hook 'foo)
         (insert mock-srt-data)
         (subed-jump-to-subtitle-id 1)
         (expect (subed-adjust-subtitle-time-start 100) :to-equal 100)
@@ -181,8 +181,7 @@ Baz.
         (expect 'foo :to-have-been-called-times 3)
         (expect (subed-adjust-subtitle-time-stop 123) :to-equal 123)
         (expect 'foo :to-have-been-called-with 122240)
-        (expect 'foo :to-have-been-called-times 4))
-      (remove-hook 'subed-subtitle-time-adjusted-hook 'foo)))
+        (expect 'foo :to-have-been-called-times 4))))
   (it "adjusts the start/stop time."
     (with-temp-srt-buffer
       (insert mock-srt-data)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]