emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/subed e1fd29b 312/389: subed-srt--regenerate-ids: Do not m


From: ELPA Syncer
Subject: [nongnu] elpa/subed e1fd29b 312/389: subed-srt--regenerate-ids: Do not modify empty buffer
Date: Fri, 3 Dec 2021 11:00:48 -0500 (EST)

branch: elpa/subed
commit e1fd29b291c7d20720e6aa6e0615f2a1a2eb36d9
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>

    subed-srt--regenerate-ids: Do not modify empty buffer
---
 subed/subed-srt.el      | 7 ++++---
 tests/test-subed-srt.el | 7 ++++++-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/subed/subed-srt.el b/subed/subed-srt.el
index df075de..8d81840 100644
--- a/subed/subed-srt.el
+++ b/subed/subed-srt.el
@@ -425,9 +425,10 @@ Return new point."
       (save-excursion
         (goto-char (point-min))
         (subed-srt--jump-to-subtitle-id)
-        (unless (string= (current-word) "1")
-          (delete-region (point) (progn (forward-word 1) (point)))
-          (insert "1"))
+        (when (looking-at "^[[:digit:]]+$")
+          (unless (string= (current-word) "1")
+            (delete-region (point) (progn (forward-word 1) (point)))
+            (insert "1")))
         (let ((id 2))
           (while (subed-srt--forward-subtitle-id)
             (let ((id-str (number-to-string id)))
diff --git a/tests/test-subed-srt.el b/tests/test-subed-srt.el
index b2a2008..974fe17 100644
--- a/tests/test-subed-srt.el
+++ b/tests/test-subed-srt.el
@@ -1410,7 +1410,12 @@ Baz.
       (while (looking-at "^[0-9]$")
         (insert "555"))
       (subed-srt--regenerate-ids)
-      (expect (car kill-ring) :to-equal "asdf"))))
+      (expect (car kill-ring) :to-equal "asdf")))
+  (it "does not modify empty buffer."
+    (with-temp-srt-buffer
+      (subed-srt--regenerate-ids)
+      (expect (buffer-string) :to-equal "")))
+  )
 
 (describe "Sorting"
   (it "orders subtitles by start time."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]