emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/subed 11a1993 275/389: Don't modify kill-ring when regener


From: ELPA Syncer
Subject: [nongnu] elpa/subed 11a1993 275/389: Don't modify kill-ring when regenerating IDs
Date: Fri, 3 Dec 2021 11:00:40 -0500 (EST)

branch: elpa/subed
commit 11a199308dc1d920b818377d8df08239da5114a2
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>

    Don't modify kill-ring when regenerating IDs
---
 subed/subed-srt.el      |  4 ++--
 tests/test-subed-srt.el | 11 ++++++++++-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/subed/subed-srt.el b/subed/subed-srt.el
index 05f6ece..ca98899 100644
--- a/subed/subed-srt.el
+++ b/subed/subed-srt.el
@@ -429,13 +429,13 @@ Return new point."
         (goto-char (point-min))
         (subed-srt--jump-to-subtitle-id)
         (unless (string= (current-word) "1")
-          (kill-word 1)
+          (delete-region (point) (progn (forward-word 1) (point)))
           (insert "1"))
         (let ((id 2))
           (while (subed-srt--forward-subtitle-id)
             (let ((id-str (number-to-string id)))
               (unless (string= (current-word) id-str)
-                (kill-word 1)
+                (delete-region (point) (progn (forward-word 1) (point)))
                 (insert id-str)))
             (setq id (1+ id))))))))
 
diff --git a/tests/test-subed-srt.el b/tests/test-subed-srt.el
index b8640bc..71de61a 100644
--- a/tests/test-subed-srt.el
+++ b/tests/test-subed-srt.el
@@ -1379,7 +1379,16 @@ Baz.
         (replace-match "123"))
       (expect (buffer-string) :not :to-equal mock-srt-data)
       (subed-srt--regenerate-ids)
-      (expect (buffer-string) :to-equal mock-srt-data))))
+      (expect (buffer-string) :to-equal mock-srt-data)))
+  (it "does not modify the kill-ring."
+    (with-temp-srt-buffer
+      (insert mock-srt-data)
+      (kill-new "asdf")
+      (goto-char (point-min))
+      (while (looking-at "^[0-9]$")
+        (replace-match "555"))
+      (subed-srt--regenerate-ids)
+      (expect (buffer-string) :to-equal mock-srt-data)
 
 (describe "Sorting"
   (it "orders subtitles by start time."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]