[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/subed 11a1993 275/389: Don't modify kill-ring when regener
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/subed 11a1993 275/389: Don't modify kill-ring when regenerating IDs |
Date: |
Fri, 3 Dec 2021 11:00:40 -0500 (EST) |
branch: elpa/subed
commit 11a199308dc1d920b818377d8df08239da5114a2
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>
Don't modify kill-ring when regenerating IDs
---
subed/subed-srt.el | 4 ++--
tests/test-subed-srt.el | 11 ++++++++++-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/subed/subed-srt.el b/subed/subed-srt.el
index 05f6ece..ca98899 100644
--- a/subed/subed-srt.el
+++ b/subed/subed-srt.el
@@ -429,13 +429,13 @@ Return new point."
(goto-char (point-min))
(subed-srt--jump-to-subtitle-id)
(unless (string= (current-word) "1")
- (kill-word 1)
+ (delete-region (point) (progn (forward-word 1) (point)))
(insert "1"))
(let ((id 2))
(while (subed-srt--forward-subtitle-id)
(let ((id-str (number-to-string id)))
(unless (string= (current-word) id-str)
- (kill-word 1)
+ (delete-region (point) (progn (forward-word 1) (point)))
(insert id-str)))
(setq id (1+ id))))))))
diff --git a/tests/test-subed-srt.el b/tests/test-subed-srt.el
index b8640bc..71de61a 100644
--- a/tests/test-subed-srt.el
+++ b/tests/test-subed-srt.el
@@ -1379,7 +1379,16 @@ Baz.
(replace-match "123"))
(expect (buffer-string) :not :to-equal mock-srt-data)
(subed-srt--regenerate-ids)
- (expect (buffer-string) :to-equal mock-srt-data))))
+ (expect (buffer-string) :to-equal mock-srt-data)))
+ (it "does not modify the kill-ring."
+ (with-temp-srt-buffer
+ (insert mock-srt-data)
+ (kill-new "asdf")
+ (goto-char (point-min))
+ (while (looking-at "^[0-9]$")
+ (replace-match "555"))
+ (subed-srt--regenerate-ids)
+ (expect (buffer-string) :to-equal mock-srt-data)
(describe "Sorting"
(it "orders subtitles by start time."
- [nongnu] elpa/subed c3e67ec 250/389: Add/Reword some features, (continued)
- [nongnu] elpa/subed c3e67ec 250/389: Add/Reword some features, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d27e55a 253/389: Move most stuff from subed.el to subed-common.el, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed b988a17 257/389: subed-replay-adjusted-subtitle-p: Fix if/when in docstring, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 080e512 262/389: Make variable subed-subtitle-format private, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed e7e791f 265/389: Activate support for multiple subtitle formats, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 831b0ea 267/389: Produce better error message when buffer-file-name is nil, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 864748c 270/389: Point to subed-mode docstring in "Commentary", ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 802a603 272/389: Add a real version number, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 9557ba9 273/389: Standardize/Rename subtitle loop functions, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed ccc4c0e 274/389: Loop over current subtitle by default, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 11a1993 275/389: Don't modify kill-ring when regenerating IDs,
ELPA Syncer <=
- [nongnu] elpa/subed e3d4f46 283/389: Reword test description, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed fcc1951 288/389: Add subed-mpv-file-loaded-hook, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed d87e2cd 290/389: Add save-place-local-mode to example config, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed e7ae26e 292/389: Add target: clean, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 73e11d4 291/389: Define subed-mode as derived mode, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed df96747 297/389: Rename subed-mpv--handle-event -> subed-mpv--client-handle-event, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 4ef1646 298/389: subed-mpv-find-video: Kill previous mpv instance if existing, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 0872ab7 299/389: Remove "subed-mode enabled" message, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 6215cb1 300/389: Add test-compile target, ELPA Syncer, 2021/12/03
- [nongnu] elpa/subed 9078a46 303/389: subed-srt--validate: Don't complain if buffer contains only whitespace, ELPA Syncer, 2021/12/03