emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/subed 61cf9ce 129/389: Remove garbage tests for point-to-p


From: ELPA Syncer
Subject: [nongnu] elpa/subed 61cf9ce 129/389: Remove garbage tests for point-to-player syncing
Date: Fri, 3 Dec 2021 11:00:11 -0500 (EST)

branch: elpa/subed
commit 61cf9ceba777748af99e897643203234e6e27085
Author: Random User <rndusr@posteo.de>
Commit: Random User <rndusr@posteo.de>

    Remove garbage tests for point-to-player syncing
    
    It looks like I copy-and-pasted them from the player-to-point tests but 
never
    rewrote them.
    
    Ideally, there would tests for point-to-player syncing, but all the 
complexity
    is in the underlying functions that already have tests.
---
 tests/test-subed.el | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/tests/test-subed.el b/tests/test-subed.el
index 7496286..c5b8266 100644
--- a/tests/test-subed.el
+++ b/tests/test-subed.el
@@ -238,30 +238,6 @@
               (expect 'subed-mpv-jump :to-have-been-called-with 5000))
           )
 
-(describe "Syncing point to player"
-          :var (subed-mpv-playback-position)
-          (before-each
-           (setq subed-mpv-playback-position 0)
-           (spy-on 'subed--subtitle-msecs-start :and-return-value 5000)
-           (spy-on 'subed--subtitle-msecs-stop :and-return-value 6500)
-           (spy-on 'subed-mpv-jump))
-          (it "does not seek player if point is on current subtitle."
-              (setq subed-mpv-playback-position 5000)
-              (subed--sync-player-to-point)
-              (expect 'subed-mpv-jump :not :to-have-been-called)
-              (setq subed-mpv-playback-position 6500)
-              (subed--sync-player-to-point)
-              (expect 'subed-mpv-jump :not :to-have-been-called))
-          (it "seeks player if point is on future subtitle."
-              (setq subed-mpv-playback-position 6501)
-              (subed--sync-player-to-point)
-              (expect 'subed-mpv-jump :to-have-been-called-with 5000))
-          (it "seeks player if point is on past subtitle."
-              (setq subed-mpv-playback-position 4999)
-              (subed--sync-player-to-point)
-              (expect 'subed-mpv-jump :to-have-been-called-with 5000))
-          )
-
 (describe "Temporarily disabling point-to-player syncing"
           (before-each
            (spy-on 'subed-disable-sync-point-to-player))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]