[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/marginalia 7a0c2c6 173/241: marginalia-cycle: remove mi
From: |
Stefan Monnier |
Subject: |
[elpa] externals/marginalia 7a0c2c6 173/241: marginalia-cycle: remove minibuffer local behavior |
Date: |
Fri, 28 May 2021 20:49:21 -0400 (EDT) |
branch: externals/marginalia
commit 7a0c2c61c6c2898f351bfd6a31767ff05e444da9
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>
marginalia-cycle: remove minibuffer local behavior
* Simply change the annotations globally
* The local behavior is confusing and unnecessary
* It does not work well with annotate-consult-multi
---
marginalia.el | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/marginalia.el b/marginalia.el
index 245a057..106c438 100644
--- a/marginalia.el
+++ b/marginalia.el
@@ -712,20 +712,10 @@ Remember `this-command' for
`marginalia-classify-by-command-name'."
;; the discussion in https://github.com/minad/marginalia/issues/10 for
reference.
;;;###autoload
(defun marginalia-cycle ()
- "Cycle between annotators in `marginalia-annotators'.
-If called from the minibuffer the annotator cycling is local,
-that it is, it does not affect subsequent minibuffers. When called
-from a regular buffer the effect is global."
+ "Cycle between annotators in `marginalia-annotators'."
(interactive)
- ;; If `marginalia-cycle' has been invoked from inside the minibuffer, only
change the annotators
- ;; locally. This is useful if the command is used as an action. If the
command is not triggered
- ;; from inside the minibuffer, cycle the annotator globally. Hopefully this
is not too confusing.
- (if-let* ((win (active-minibuffer-window))
- (buf (window-buffer win)))
- (let ((a (buffer-local-value 'marginalia-annotators buf)))
- (setf (buffer-local-value 'marginalia-annotators buf) (append (cdr a)
(list (car a)))))
- (let ((a marginalia-annotators))
- (setq marginalia-annotators (append (cdr a) (list (car a)))))))
+ (setq marginalia-annotators (append (cdr marginalia-annotators)
+ (list (car marginalia-annotators)))))
(provide 'marginalia)
;;; marginalia.el ends here
- [elpa] externals/marginalia a78a4b3 149/241: fix headline, (continued)
- [elpa] externals/marginalia a78a4b3 149/241: fix headline, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 6c8b158 030/241: add license, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia f7adb62 044/241: fix #14, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 6567947 050/241: marginalia-annotate-command-binding: use a hash table per buffer, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 1077dba 123/241: update comment, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 54a61c7 137/241: update marginalia comment, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 35a42dc 142/241: improve buffer directory annotation, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 909b731 160/241: fix #42 - wrapping/alignment problem at the right margin, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia c5e89cf 168/241: describe-symbol: add indicator for obsolete variables/functions, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia d489f4c 171/241: fix #55, use string-width instead of length for alignment, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 7a0c2c6 173/241: marginalia-cycle: remove minibuffer local behavior,
Stefan Monnier <=
- [elpa] externals/marginalia 86c0461 180/241: consult-multi annotator should delegate to original annotation function, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 2f977a1 181/241: readme: add illustration, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia e741b24 194/241: Version 0.4, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 06ae3b4 204/241: Some minor improvements on the fix, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia a8e73d9 198/241: Fix overly wide docstring warning, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 5126ba6 223/241: Version 0.5, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 9389f38 217/241: completion-all-completions: Last cdr can also be nil, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 287a369 221/241: Use more strict definition of the affixation function., Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia d1b836d 225/241: Go back to obsolete function project-roots, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 0c24618 233/241: marginalia-bookmark-type-transformers: Use more precise type, Stefan Monnier, 2021/05/28