[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/marginalia 785297d 075/241: Indicate advised functions
From: |
Stefan Monnier |
Subject: |
[elpa] externals/marginalia 785297d 075/241: Indicate advised functions with an asterisk |
Date: |
Fri, 28 May 2021 20:49:00 -0400 (EDT) |
branch: externals/marginalia
commit 785297d9f98d4d23a1bf9f047e6aeca889e3f9ea
Author: Omar Antolín <omar.antolin@gmail.com>
Commit: Omar Antolín <omar.antolin@gmail.com>
Indicate advised functions with an asterisk
Part of the work on issue #19.
Should we apply a face to the asterisk?
---
marginalia.el | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/marginalia.el b/marginalia.el
index 2020a3d..b6d795d 100644
--- a/marginalia.el
+++ b/marginalia.el
@@ -291,6 +291,16 @@ This hash table is needed to speed up
`marginalia-annotate-command-binding'.")
(marginalia-annotate-command-binding cand)
(marginalia-annotate-symbol cand)))
+(defconst marginalia--advice-regexp
+ (rx bos
+ (1+ (seq (? "This function has ")
+ (or ":before" ":after" ":around" ":override"
+ ":before-while" ":before-until" ":after-while"
+ ":after-until" ":filter-args" ":filter-return")
+ " advice: " (0+ nonl) "\n"))
+ "\n")
+ "Regexp to match lines about advice in function documentation strings.")
+
(defun marginalia-annotate-symbol (cand)
"Annotate symbol CAND with its documentation string."
(when-let ((sym (intern-soft cand)))
@@ -298,16 +308,11 @@ This hash table is needed to speed up
`marginalia-annotate-command-binding'.")
(cond
((fboundp sym)
(when-let ((doc (ignore-errors (documentation sym))))
- (replace-regexp-in-string
- (rx bos
- (1+ (seq (? "This function has ")
- (or ":before" ":after" ":around" ":override"
- ":before-while" ":before-until" ":after-while"
- ":after-until" ":filter-args" ":filter-return")
- " advice: " (0+ nonl) "\n"))
- "\n")
- ""
- doc)))
+ (if (string-match-p marginalia--advice-regexp doc)
+ (concat "*"
+ (replace-regexp-in-string
+ marginalia--advice-regexp "" doc))
+ (concat " " doc))))
((facep sym) (documentation-property sym 'face-documentation))
(t (documentation-property sym 'variable-documentation))))))
- [elpa] externals/marginalia 7fe8f71 027/241: improve buffer annotation formatting, (continued)
- [elpa] externals/marginalia 7fe8f71 027/241: improve buffer annotation formatting, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 4ba9804 031/241: Fix bug: file annotations were only shown for current directory, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 78023eb 038/241: update readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia b6d2e22 037/241: fix typo, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 472b47a 041/241: add comment to marginalia-toggle-annotators, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 85a2693 053/241: marginalia-annotate-package: show package archive, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia dfbaa7f 061/241: marginalia-annotate-package: show installed status instead of archive, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 17d539c 059/241: whitespace and comment adjustments, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 4a5ada6 063/241: smaller variable field, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 2f1bb7c 064/241: do not overwrite the face weights as per recommendation by @purcell, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 785297d 075/241: Indicate advised functions with an asterisk,
Stefan Monnier <=
- [elpa] externals/marginalia 0bd8061 077/241: marginalia--fields: allow alignment to the right by using a negative width, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia f16d26a 082/241: marginalia-annotate-symbol: add keybindings to commands, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia b0c24f7 088/241: introduce marginalia-annotate-command, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia bbde111 083/241: Annotate environment variables with their value, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 618fd9e 084/241: Improve formatting of environment variable annotation, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 3559cbb 095/241: update readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 27cd29d 101/241: add buffer size annotation, fix #29, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 3360875 113/241: Rename marginalia-cycle-annotators to marginalia-cycle, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 1fb2569 121/241: marginalia-annotate-minor-mode: fix support for consult, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 35cb523 127/241: add comment, Stefan Monnier, 2021/05/28