[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/marginalia a6dfb38 003/241: add todos
From: |
Stefan Monnier |
Subject: |
[elpa] externals/marginalia a6dfb38 003/241: add todos |
Date: |
Fri, 28 May 2021 20:48:45 -0400 (EDT) |
branch: externals/marginalia
commit a6dfb38738bddf7aaf25654d26ffe0faa6cefed7
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>
add todos
---
marginalia.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/marginalia.el b/marginalia.el
index c1c08a4..68130d9 100644
--- a/marginalia.el
+++ b/marginalia.el
@@ -229,6 +229,12 @@ PROP is the property which is looked up."
"Setup minibuffer for `marginalia-mode'.
Remember `this-command' for annotation and replace highlighting function."
(setq-local marginalia--this-command this-command)
+ ;; TODO we use selectrum-highlight-candidates-function here because
annotation faces
+ ;; are overwritten if we use the Emacs annotation-function with selectrum is
used.
+ ;; While this is consistent with the behavior of the Completions buffer, it
is not
+ ;; what I want e.g. for marginalia-annotate-face!
+ ;; How to proceed?
+ ;; See https://github.com/raxod502/selectrum/pull/249
(when (boundp 'selectrum-highlight-candidates-function)
(let ((orig selectrum-highlight-candidates-function))
(setq-local selectrum-highlight-candidates-function
@@ -265,6 +271,7 @@ Remember `this-command' for annotation and replace
highlighting function."
;; https://github.com/oantolin/icomplete-vertical/issues/16
(advice-add #'completion-metadata-get :around
#'marginalia--completion-metadata-get)))
+;; TODO better name? there is also the name clash problem with
marginalia-annotate-command
;;;###autoload
(defun marginalia-command-annotate (cmd ann)
"Modify marginalia configuration such that annotation function ANN is used
for command CMD."
- [elpa] branch externals/marginalia created (now 529aee6), Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 84f0fde 002/241: add marginalia-command-annotate, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia eecc6e2 006/241: Get key binding active in next window instead of in the minibuffer, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 863e07b 004/241: experimental: remove selectrum-specifics (may not work out!), Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia e863b6c 007/241: Show key bindings from minibuffer-selected-window, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 4780a6a 009/241: marginalia works with icomplete-vertical now!, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 237a620 001/241: initial prototype, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia c47576c 010/241: add configuration example, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia a6dfb38 003/241: add todos,
Stefan Monnier <=
- [elpa] externals/marginalia bdbbee2 005/241: add very basic readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 6077206 008/241: Ignore byte-compiled files, autoloads and *-pkg.el files, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 0c090f3 011/241: improve readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 80fa320 016/241: Introduce list of classifiers, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia ca21d30 029/241: fix typo in the readme, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 655f03b 035/241: introduce marginalia-annotators-(light|heavy), remove marginalia-set-command-annotator, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 4cb6d2b 039/241: marginalia-annotate-file: add modes, user and group, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia ed74ca9 040/241: add marginalia-toggle-annotators, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 57b1176 051/241: marginalia-annotate-command-binding: only store the binding in the hash table, Stefan Monnier, 2021/05/28
- [elpa] externals/marginalia 6537c37 015/241: Shorten first line of docstring using our "annotator" term, Stefan Monnier, 2021/05/28