[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/emms b8e1de7 17/80: Clean up Opus code
From: |
Stefan Monnier |
Subject: |
[elpa] externals/emms b8e1de7 17/80: Clean up Opus code |
Date: |
Wed, 17 Mar 2021 18:42:21 -0400 (EDT) |
branch: externals/emms
commit b8e1de743ba4a346044225ba68a688e2ead0d590
Author: Petteri Hintsanen <petterih@iki.fi>
Commit: Petteri Hintsanen <petterih@iki.fi>
Clean up Opus code
These are only stylistic changes.
---
emms-info-native.el | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/emms-info-native.el b/emms-info-native.el
index f253791..39b4fd9 100644
--- a/emms-info-native.el
+++ b/emms-info-native.el
@@ -371,13 +371,13 @@ lower case and VALUE is the decoded value."
(defconst emms-info-native--opus-identification-header-bindat-spec
'((opus-head vec 8)
- (eval (when (not (equal last emms-info-native--opus-head-magic-array))
+ (eval (unless (equal last emms-info-native--opus-head-magic-array)
(error "Opus framing mismatch: expected ‘%s’, got ‘%s’"
emms-info-native--opus-head-magic-array
last)))
(opus-version u8)
- (eval (when (not (< last 16))
- (error "Opus version mismatch: expected less than 16, got %s"
+ (eval (unless (< last 16)
+ (error "Opus version mismatch: expected < 16, got %s"
last)))
(channel-count u8)
(pre-skip u16r)
@@ -385,13 +385,11 @@ lower case and VALUE is the decoded value."
(output-gain u16r)
(channel-mapping-family u8)
(eval (> last 0) (struct opus-channel-mapping-table)))
- "Opus identification header specification.
-Framing and version data are verified, otherwise the data is
-assumed to be valid.")
+ "Opus identification header specification.")
(defconst emms-info-native--opus-comment-header-bindat-spec
'((opus-tags vec 8)
- (eval (when (not (equal last emms-info-native--opus-tags-magic-array))
+ (eval (unless (equal last emms-info-native--opus-tags-magic-array)
(error "Opus framing mismatch: expected ‘%s’, got ‘%s’"
emms-info-native--opus-tags-magic-array
last)))
@@ -401,13 +399,12 @@ assumed to be valid.")
(vendor-string vec (vendor-length))
(user-comments-list-length u32r)
(eval (when (> last emms-info-native--max-num-vorbis-comments)
- (error "Opus user comment list length %s is too long" last)))
+ (error "Opus user comment list length %s is too long"
+ last)))
(user-comments repeat
(user-comments-list-length)
(struct
emms-info-native--vorbis-comment-field-bindat-spec)))
- "Opus comment header specification.
-Framing is verified. Too long vendor string and comment list
-will also trigger an error.")
+ "Opus comment header specification.")
(defconst emms-info-native--opus-headers-bindat-spec
'((identification-header struct
emms-info-native--opus-identification-header-bindat-spec)
- [elpa] externals/emms 82a9086 04/80: * doc/emms.texinfo: add setup example, (continued)
- [elpa] externals/emms 82a9086 04/80: * doc/emms.texinfo: add setup example, Stefan Monnier, 2021/03/17
- [elpa] externals/emms b7f6e50 08/80: Merge remote-tracking branch 'origin/docs', Stefan Monnier, 2021/03/17
- [elpa] externals/emms a431263 09/80: * doc/emms.texinfo: update copyright years, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 5c3226b 10/80: * doc/developer-release.txt: remove duplicate, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 50bdbcc 12/80: * emms-tag-editor.el: Add emms-tag-editor-pipe, Stefan Monnier, 2021/03/17
- [elpa] externals/emms bc5e516 14/80: Add id3v2 (MP3) support to emms-info-native, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 9c8d961 15/80: Simplify Ogg-related code, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 17e5c6a 05/80: * doc/emms.texinfo: setup examples, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 209077e 07/80: * doc/emms.texinfo: update manual, Stefan Monnier, 2021/03/17
- [elpa] externals/emms d0142e7 11/80: Merge branch 'info-native', Stefan Monnier, 2021/03/17
- [elpa] externals/emms b8e1de7 17/80: Clean up Opus code,
Stefan Monnier <=
- [elpa] externals/emms 810dd41 18/80: Fix typos in Commentary, Stefan Monnier, 2021/03/17
- [elpa] externals/emms dbcc614 24/80: Fix id3v2 bugs, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 0f11ae1 22/80: Reorder functions and constants, Stefan Monnier, 2021/03/17
- [elpa] externals/emms e89bc15 26/80: Merge branch 'info-native', Stefan Monnier, 2021/03/17
- [elpa] externals/emms fa8f64e 33/80: Fix whitespace trimming, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 5aea8e7 35/80: Fix id3v2 frame id to info-field mapping, Stefan Monnier, 2021/03/17
- [elpa] externals/emms f9f2bab 30/80: Trim trailing whitespace from id3v2 strings, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 60c9304 32/80: Trim trailing whitespace from all info-fields, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 6e5d477 21/80: Simplify FLAC code, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 757043b 41/80: Merge branch 'info-native', Stefan Monnier, 2021/03/17