scratch/emacs-editorconfig 8a5e621265c 118/364: Avoid asking coding system when not specified (#102)

[Stefan Monnier]

branch: scratch/emacs-editorconfig
commit 8a5e621265c4a5cb92876015699793f884876769
Author: 10sr <8slashes+git@gmail.com>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    Avoid asking coding system when not specified (#102)
    
    Why ?
    
    In short: Emacs always asks which charset to use when
    editorconfig-mode is enabled, .editorconfig does not exist and trying
    to save files with non-ascii characters.  This is an annoying behavior
    so stop it.
    
    Calling `set-buffer-file-coding-system` sets the "explicit" flag, and
    it is used just before saving files.
    When this flag is set but the charset is `undecided`, Emacs asks
    users what charset to use for saving files with non-ascii
    characters (when this flag is not set Emacs do not ask and decide
    to use something automatically, `utf-8` for my environment).
    
    This typically happens when editing files in repositories without
    .editorconfig, and it is a bit annoying behavior.
    This change makes this plugin not call `set-buffer-file-coding-system`
    at all when neither `charset` nor `end_of_line` is provided, thus
    Emacs can decide charset automatically when saving files in
    repositories without .editorconfig files.
---
 editorconfig.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/editorconfig.el b/editorconfig.el
index 6b234e3fc76..0ff3e57c252 100644
--- a/editorconfig.el
+++ b/editorconfig.el
@@ -176,10 +176,12 @@ yet.")
                ((equal charset "utf-16be") 'utf-16be)
                ((equal charset "utf-16le") 'utf-16le)
                (t 'undecided))))
-    (set-buffer-file-coding-system (merge-coding-systems
-                                     cs
-                                     eol)
-      nil t)))
+    (unless (and (eq eol 'undecided)
+              (eq cs 'undecided))
+      (set-buffer-file-coding-system (merge-coding-systems
+                                       cs
+                                       eol)
+        nil t))))
 
 
 (defun editorconfig-set-line-length (length)