emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master d5773276fb1: (comp-known-predicates): Fix overly optimistic `func


From: Stefan Monnier
Subject: master d5773276fb1: (comp-known-predicates): Fix overly optimistic `functionp`
Date: Tue, 12 Mar 2024 08:48:17 -0400 (EDT)

branch: master
commit d5773276fb1671da619eeee2c316098d6b1c25c4
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    (comp-known-predicates): Fix overly optimistic `functionp`
    
    * lisp/emacs-lisp/comp.el (comp-known-predicates): `functionp` can also
    be true for `cons` objects.
---
 lisp/emacs-lisp/comp.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 21e2bb01ed0..9c2182092cb 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -202,7 +202,7 @@ Useful to hook into pass checkers.")
     (consp               . cons)
     (floatp              . float)
     (framep              . frame)
-    (functionp           . (or function symbol))
+    (functionp           . (or function symbol cons))
     (hash-table-p       . hash-table)
     (integer-or-marker-p . integer-or-marker)
     (integerp            . integer)
@@ -244,6 +244,7 @@ Useful to hook into pass checkers.")
 
 (defun comp--pred-to-cstr (predicate)
   "Given PREDICATE, return the corresponding constraint."
+  ;; FIXME: Unify those two hash tables?
   (or (gethash predicate comp-known-predicates-h)
       (gethash predicate (comp-cstr-ctxt-pred-type-h comp-ctxt))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]