[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/completion-lazy-hilit d91085807cc 1/2: Revert "Fix performance r
From: |
João Távora |
Subject: |
feature/completion-lazy-hilit d91085807cc 1/2: Revert "Fix performance regression in completion-pcm--all-completions" |
Date: |
Fri, 27 Oct 2023 12:56:46 -0400 (EDT) |
branch: feature/completion-lazy-hilit
commit d91085807cc16867f4bd9400dae63bef12f1bb2d
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>
Revert "Fix performance regression in completion-pcm--all-completions"
The performance optimization introduces problems and isn't worth it.
bug#48841, bug#47711
This reverts commit 54a6079ba4c94ba6d8b56987400feeabe0c77955.
---
lisp/minibuffer.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index c32bcee51ed..b38eb49aba8 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -3738,9 +3738,10 @@ PATTERN is as returned by
`completion-pcm--string->pattern'."
(t
;; The pattern has something interesting to match, in
;; which case we take the opportunity to add an early
- ;; `completion-score' cookie to each completion.
+ ;; completion-score cookie to each completion.
(cl-loop with re = (completion-pcm--pattern->regex pattern 'group)
- for comp in completions
+ for orig in completions
+ for comp = (copy-sequence orig)
for score = (completion--flex-score comp re t)
when score
do (put-text-property 0 1 'completion-score