emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master c2e4c68333d: Eglot: another tweak to eglot--sig-info


From: João Távora
Subject: master c2e4c68333d: Eglot: another tweak to eglot--sig-info
Date: Sun, 2 Jul 2023 06:57:10 -0400 (EDT)

branch: master
commit c2e4c68333d72a342bb531449412a424b3507a65
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>

    Eglot: another tweak to eglot--sig-info
    
    Going to the start of the first param and skipping non-word syntax
    backward would seem to be the right thing to do, for traditional
    C-style languages and also languages like Ocaml where function
    signatures don't start the param list with '('.
    
    See also https://github.com/joaotavora/eglot/discussions/1251.
    
    * lisp/progmodes/eglot.el (eglot--sig-info): Rework again.
---
 lisp/progmodes/eglot.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 897cf3bc93e..f09c348143d 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -3212,7 +3212,7 @@ for which LSP on-type-formatting should be requested."
            parameter
          (when (zerop i)
            (goto-char (elt parlabel 0))
-           (search-backward "(" nil t)
+           (skip-syntax-backward "^w")
            (add-face-text-property (point-min) (point)
                                    'font-lock-function-name-face))
          ;; ...perhaps highlight it in the formals list



reply via email to

[Prev in Thread] Current Thread [Next in Thread]