[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master f20fe3e11a9 1/7: Eglot: more leniently handle 'window/showMessage
From: |
João Távora |
Subject: |
master f20fe3e11a9 1/7: Eglot: more leniently handle 'window/showMessageRequest' |
Date: |
Thu, 23 Mar 2023 17:17:42 -0400 (EDT) |
branch: master
commit f20fe3e11a96defe69e7cfed801a047be1778b51
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>
Eglot: more leniently handle 'window/showMessageRequest'
Some servers mess up this message's arguments.
* lisp/progmodes/eglot.el (eglot-handle-request): Fix.
---
lisp/progmodes/eglot.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 058bcec1489..9fd12d174da 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -2136,13 +2136,14 @@ COMMAND is a symbol naming the command."
type message))
(cl-defmethod eglot-handle-request
- (_server (_method (eql window/showMessageRequest)) &key type message actions)
+ (_server (_method (eql window/showMessageRequest))
+ &key type message actions &allow-other-keys)
"Handle server request window/showMessageRequest."
(let* ((actions (append actions nil)) ;; gh#627
(label (completing-read
(concat
(format (propertize "[eglot] Server reports (type=%s): %s"
- 'face (if (<= type 1) 'error))
+ 'face (if (or (not type) (<= type 1))
'error))
type message)
"\nChoose an option: ")
(or (mapcar (lambda (obj) (plist-get obj :title)) actions)
- master updated (b19d040a4fe -> 4566a0c6b82), João Távora, 2023/03/23
- master 9b18407c7fd 3/7: ElDoc: remember origin backend in doc snippets (bug#62029), João Távora, 2023/03/23
- master e19994fe8c0 4/7: ElDoc: rework rendering of echo area (bug#62029), João Távora, 2023/03/23
- master 0effdb29d6d 2/7: Eglot: rework progress indicators, João Távora, 2023/03/23
- master f20fe3e11a9 1/7: Eglot: more leniently handle 'window/showMessageRequest',
João Távora <=
- master 67c1e6e89ce 5/7: Eglot: inform ElDoc about overly long 'hover' docs, João Távora, 2023/03/23
- master fe8af4eb30b 6/7: Eglot: don't send invisible text to Eldoc, João Távora, 2023/03/23
- master 4566a0c6b82 7/7: Eglot: let user opt-in to plaintext LSP docs (bug#61373), João Távora, 2023/03/23