emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master f3769bc32a: org.el: Improve bindings of `inhibit-*` vars


From: Stefan Monnier
Subject: master f3769bc32a: org.el: Improve bindings of `inhibit-*` vars
Date: Fri, 7 Oct 2022 12:30:05 -0400 (EDT)

branch: master
commit f3769bc32a3d32377a83b33d416205f80814e422
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    org.el: Improve bindings of `inhibit-*` vars
    
    Remove binding of `inhibit-point-motion-hooks` (it's t by default
    anyway and it's obsolete) and don't "manually" bind
    `inhibit-modification-hooks`.
    
    * lisp/org/org.el (org-unfontify-region): Use `with-silent-modifications`.
    (org-display-inline-remove-overlay): Remove ineffective binding of
    `inhibit-modification-hooks` around code which doesn't modify the
    buffer anyway.
---
 lisp/org/org.el | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/lisp/org/org.el b/lisp/org/org.el
index 6f92cdeab5..7de907590e 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -5929,10 +5929,7 @@ If TAG is a number, get the corresponding match group."
 (defun org-unfontify-region (beg end &optional _maybe_loudly)
   "Remove fontification and activation overlays from links."
   (font-lock-default-unfontify-region beg end)
-  (let* ((buffer-undo-list t)
-        (inhibit-read-only t) (inhibit-point-motion-hooks t)
-        (inhibit-modification-hooks t)
-        deactivate-mark buffer-file-name buffer-file-truename)
+  (with-silent-modifications
     (decompose-region beg end)
     (remove-text-properties beg end
                            '(mouse-face t keymap t org-linked-text t
@@ -16702,10 +16699,9 @@ buffer boundaries with possible narrowing."
 
 (defun org-display-inline-remove-overlay (ov after _beg _end &optional _len)
   "Remove inline-display overlay if a corresponding region is modified."
-  (let ((inhibit-modification-hooks t))
-    (when (and ov after)
-      (delete ov org-inline-image-overlays)
-      (delete-overlay ov))))
+  (when (and ov after)
+    (delete ov org-inline-image-overlays)
+    (delete-overlay ov)))
 
 (defun org-remove-inline-images ()
   "Remove inline display of images."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]