emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 60f77c58f1 1/2: Improve dired-do-{info,man} error handling


From: Stefan Kangas
Subject: master 60f77c58f1 1/2: Improve dired-do-{info,man} error handling
Date: Sun, 3 Jul 2022 05:44:53 -0400 (EDT)

branch: master
commit 60f77c58f1139e0196d859844d74cdfea5f264cf
Author: Stefan Kangas <stefan@marxist.se>
Commit: Stefan Kangas <stefan@marxist.se>

    Improve dired-do-{info,man} error handling
    
    * lisp/dired.el (dired-do-man, dired-do-info): Use
    'dired-get-file-for-visit' to get better error handling.
    Interactive mode tagging.
---
 lisp/dired.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/dired.el b/lisp/dired.el
index d7bf631688..6fe0ba0be6 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -4810,22 +4810,22 @@ Interactively with prefix argument, read FILE-NAME."
 (defvar manual-program) ; from man.el
 
 (defun dired-do-man ()
-  "Run `man' on this file."
-  (interactive)
+  "In Dired, run `man' on this file."
+  (interactive nil dired-mode)
   (require 'man)
   ;; FIXME: Move `dired-guess-shell-command' to dired.el to remove the
   ;;        need for requiring `dired-x'.
   (require 'dired-x)
-  (let* ((file (dired-get-filename))
+  (let* ((file (dired-get-file-for-visit))
          (manual-program (string-replace "*" "%s"
                                          (dired-guess-shell-command
                                           "Man command: " (list file)))))
     (Man-getpage-in-background file)))
 
 (defun dired-do-info ()
-  "Run `info' on this file."
-  (interactive)
-  (info (dired-get-filename)))
+  "In Dired, run `info' on this file."
+  (interactive nil dired-mode)
+  (info (dired-get-file-for-visit)))
 
 (provide 'dired)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]