emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 5d476a9 3/3: Add FIXME comment


From: Lars Ingebrigtsen
Subject: master 5d476a9 3/3: Add FIXME comment
Date: Sat, 11 Dec 2021 02:18:14 -0500 (EST)

branch: master
commit 5d476a9ed892e390e05eab73e7b57a4b879a1780
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Add FIXME comment
    
    * lisp/sqlite-mode.el (sqlite-mode-delete): New command.
    (sqlite--mode--list-data, sqlite-mode-list-data): Adjust to new
    command.
---
 lisp/sqlite-mode.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lisp/sqlite-mode.el b/lisp/sqlite-mode.el
index 5e0410e..48916b2 100644
--- a/lisp/sqlite-mode.el
+++ b/lisp/sqlite-mode.el
@@ -178,7 +178,10 @@
     (when (or (not (consp table))
               (not (eq (car table) 'row)))
       (user-error "No row under point"))
-    ;; We have to remove all open statements before we can delete something.
+    ;; We have to remove all open statements before we can delete
+    ;; something.  FIXME -- perhaps this should be changed not to use
+    ;; long-lived statements, since this presumably locks the file for
+    ;; other users, too.
     (dolist (stmt sqlite-mode--statements)
       (ignore-errors (sqlite-finalize stmt)))
     (setq sqlite-mode--statements nil)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]