[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 9171061: EIEIO: Remove redundant type info in help

From: Stefan Monnier
Subject: master 9171061: EIEIO: Remove redundant type info in help
Date: Sun, 5 Dec 2021 21:08:05 -0500 (EST)

branch: master
commit 9171061352a019acd5a4d6fef36cddfd78cf4ac1
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    EIEIO: Remove redundant type info in help
    `C-h o` returned redundant info when used on EIEIO classes, listing
    the same thing both for the type name and for the constructor name.
    * lisp/emacs-lisp/eieio.el (help-fns-describe-function-functions):
    Remove special case for defclass constructors.
    * lisp/emacs-lisp/eieio-opt.el (eieio-help-constructor): Declare it 
 lisp/emacs-lisp/eieio-opt.el | 1 +
 lisp/emacs-lisp/eieio.el     | 5 -----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/lisp/emacs-lisp/eieio-opt.el b/lisp/emacs-lisp/eieio-opt.el
index 9c842f4..3297a9d 100644
--- a/lisp/emacs-lisp/eieio-opt.el
+++ b/lisp/emacs-lisp/eieio-opt.el
@@ -130,6 +130,7 @@ are not abstract."
 (defun eieio-help-constructor (ctr)
   "Describe CTR if it is a class constructor."
+  (declare (obsolete "use describe-function or cl--describe-class" "29.1"))
   (when (class-p ctr)
     (let ((location (find-lisp-object-file-name ctr 'define-type))
diff --git a/lisp/emacs-lisp/eieio.el b/lisp/emacs-lisp/eieio.el
index 3fbfe01..2850c91 100644
--- a/lisp/emacs-lisp/eieio.el
+++ b/lisp/emacs-lisp/eieio.el
@@ -992,11 +992,6 @@ of `eq'."
   (error "EIEIO: `change-class' is unimplemented"))
 (define-obsolete-function-alias 'change-class #'eieio-change-class "26.1")
-;; Hook ourselves into help system for describing classes and methods.
-;; FIXME: This is not actually needed any more since we can click on the
-;; hyperlink from the constructor's docstring to see the type definition.
-(add-hook 'help-fns-describe-function-functions #'eieio-help-constructor)
 (provide 'eieio)
 ;;; eieio.el ends here

reply via email to

[Prev in Thread] Current Thread [Next in Thread]