emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 0601afc: src/indent.c, src/xdisp.c: Questions about with_echo_are


From: Stefan Monnier
Subject: master 0601afc: src/indent.c, src/xdisp.c: Questions about with_echo_area_buffer_unwind_data
Date: Mon, 22 Nov 2021 14:06:21 -0500 (EST)

branch: master
commit 0601afcf7c6c3498df010cef1511c38f254cbbf8
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    src/indent.c, src/xdisp.c: Questions about with_echo_area_buffer_unwind_data
---
 src/indent.c | 1 +
 src/xdisp.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/indent.c b/src/indent.c
index de6b489..914dabf 100644
--- a/src/indent.c
+++ b/src/indent.c
@@ -2051,6 +2051,7 @@ window_column_x (struct window *w, Lisp_Object window,
 
 /* Restore window's buffer and point.  */
 
+/* FIXME: Merge with `with_echo_area_buffer_unwind_data`?  */
 static void
 restore_window_buffer (Lisp_Object list)
 {
diff --git a/src/xdisp.c b/src/xdisp.c
index d965021..259d057 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -10937,6 +10937,7 @@ WINDOW.  */)
 
   /* The unwind form of with_echo_area_buffer is what we need here to
      make WINDOW temporarily show our buffer.  */
+  /* FIXME: Can we move this into the `if (!EQ (buffer, w->contents))`?  */
   record_unwind_protect (unwind_with_echo_area_buffer,
                         with_echo_area_buffer_unwind_data (w));
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]