features/user-directory 854e313 2/2: Fix file permissions when creating user directory

[Stefan Kangas]

branch: features/user-directory
commit 854e313337d6b47a308af17b830f14901a8da974
Author: Stefan Kangas <stefan@marxist.se>
Commit: Stefan Kangas <stefan@marxist.se>

    Fix file permissions when creating user directory
    
    * test/lisp/user-directory-tests.el
    (user-directory/creates-dir-if-missing): Fix typo.
    * test/lisp/user-directory-tests.el
    (user-directory/creates-dir-if-missing)
    (user-directory-tests-user-file/creates-dir-if-missing)
    (user-directory--find-or-create-dir/creates-directory): Test for
    file permissions.
---
 lisp/user-directory.el            | 2 +-
 test/lisp/user-directory-tests.el | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lisp/user-directory.el b/lisp/user-directory.el
index 28da9b2..55fe50f 100644
--- a/lisp/user-directory.el
+++ b/lisp/user-directory.el
@@ -107,7 +107,7 @@ Return value is (DIR . ERRTYPES)."
                       (or (and (file-accessible-directory-p dir)
                                (throw 'found (cons dir errtypes)))
                           (push "access" errtypes))
-                    (with-file-modes #x700
+                    (with-file-modes #o700
                       (condition-case nil
                           (progn (make-directory dir t)
                                  (setq errtypes nil)
diff --git a/test/lisp/user-directory-tests.el 
b/test/lisp/user-directory-tests.el
index 638465d..32b10e4 100644
--- a/test/lisp/user-directory-tests.el
+++ b/test/lisp/user-directory-tests.el
@@ -66,7 +66,8 @@
   (with-user-directory-test
     (delete-directory dir)
     (user-directory 'downloads)
-    (should (file-exists-p dir))))
+    (should (file-exists-p dir))
+    (should (eq (file-modes dir) #o700))))
 
 (ert-deftest user-directory/alist-entry-overrides ()
   (with-user-directory-test
@@ -139,6 +140,7 @@
         (delete-directory dir)
         (user-file 'downloads "foo/bar")
         (should (file-exists-p dir))
+        (should (eq (file-modes dir) #o700))
         ;; Sanity checks.
         (should-not (file-exists-p (expand-file-name "foo" dir)))
         (should-not (file-exists-p (expand-file-name "foo/bar")))))))
@@ -155,7 +157,8 @@
   (ert-with-temp-directory dir
     (let ((new-dir (expand-file-name "foo" dir)))
       (user-directory--find-or-create-dir (list new-dir))
-      (should (file-directory-p new-dir)))))
+      (should (file-directory-p new-dir))
+      (should (eq (file-modes new-dir) #o700)))))
 
 (ert-deftest user-directory-tests--find-or-create-dir/skips-inacessible ()
   (ert-with-temp-directory dir1