emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 5b61f2d: Harden ert-resource-directory against errors


From: Lars Ingebrigtsen
Subject: master 5b61f2d: Harden ert-resource-directory against errors
Date: Wed, 27 Oct 2021 10:04:42 -0400 (EDT)

branch: master
commit 5b61f2defe2e6332a242849bf63862053551a4c1
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Harden ert-resource-directory against errors
    
    * lisp/emacs-lisp/ert-x.el (ert-resource-directory): Be more
    resilient -- don't bug out if called from a file that's not
    visiting a directory.
---
 lisp/emacs-lisp/ert-x.el | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
index 3fc57d5..a492ef5 100644
--- a/lisp/emacs-lisp/ert-x.el
+++ b/lisp/emacs-lisp/ert-x.el
@@ -368,17 +368,17 @@ variable `ert-resource-directory-format'.  Before 
formatting, the
 file name will be trimmed using `string-trim' with arguments
 `ert-resource-directory-trim-left-regexp' and
 `ert-resource-directory-trim-right-regexp'."
-  `(let* ((testfile ,(or (macroexp-file-name)
-                         buffer-file-name))
-          (default-directory (file-name-directory testfile)))
-     (file-truename
-      (if (file-accessible-directory-p "resources/")
-          (expand-file-name "resources/")
-        (expand-file-name
-         (format ert-resource-directory-format
-                 (string-trim testfile
-                              ert-resource-directory-trim-left-regexp
-                              ert-resource-directory-trim-right-regexp)))))))
+  `(when-let ((testfile ,(or (macroexp-file-name)
+                             buffer-file-name)))
+     (let ((default-directory (file-name-directory testfile)))
+       (file-truename
+        (if (file-accessible-directory-p "resources/")
+            (expand-file-name "resources/")
+          (expand-file-name
+           (format ert-resource-directory-format
+                   (string-trim testfile
+                                ert-resource-directory-trim-left-regexp
+                                
ert-resource-directory-trim-right-regexp))))))))
 
 (defmacro ert-resource-file (file)
   "Return absolute file name of resource (test data) file named FILE.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]