master 3952737: Revert "Obsolete XEmacs compat convention in erc-button-press-button"

[Amin Bandali]

branch: master
commit 395273773cb7035358cdd7c87f9102af75e39915
Author: Amin Bandali <bandali@gnu.org>
Commit: Amin Bandali <bandali@gnu.org>

    Revert "Obsolete XEmacs compat convention in erc-button-press-button"
    
    This reverts commit f146325bd1556d1acafe26f6c263b83a92d3cd20.
    
    This should be done in 'emacs-28', which will be merged into 'master'.
---
 lisp/erc/erc-button.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el
index 2c1d700..17d5b61 100644
--- a/lisp/erc/erc-button.el
+++ b/lisp/erc/erc-button.el
@@ -389,11 +389,12 @@ REGEXP is the regular expression which matched for this 
button."
     (mouse-set-point event)
     (erc-button-press-button)))
 
+;; XEmacs calls this via widget-button-press with a bunch of arguments
+;; which we don't care about.
 (defun erc-button-press-button (&rest _ignore)
   "Check text at point for a callback function.
 If the text at point has a `erc-callback' property,
 call it with the value of the `erc-data' text property."
-  (declare (advertised-calling-convention () "29.1"))
   (interactive)
   (let* ((data (get-text-property (point) 'erc-data))
          (fun (get-text-property (point) 'erc-callback)))