[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master 0f2df36: Run ERT tests with `lexical-binding` bound to `t`
From: |
Mattias Engdegård |
Subject: |
master 0f2df36: Run ERT tests with `lexical-binding` bound to `t` |
Date: |
Mon, 4 Oct 2021 12:15:31 -0400 (EDT) |
branch: master
commit 0f2df365592636aaa6bcd72fc662774eb35c69d1
Author: Mattias Engdegård <mattiase@acm.org>
Commit: Mattias Engdegård <mattiase@acm.org>
Run ERT tests with `lexical-binding` bound to `t`
* lisp/emacs-lisp/ert.el (ert-deftest, ert--run-test-internal):
Use t rather than the ambient file value for `lexical-binding` to
avoid bad lexbind coverage by mistake.
---
lisp/emacs-lisp/ert.el | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el
index f2b20fd..607f15d 100644
--- a/lisp/emacs-lisp/ert.el
+++ b/lisp/emacs-lisp/ert.el
@@ -219,11 +219,7 @@ it has to be wrapped in `(eval (quote ...))'.
`(:expected-result-type ,expected-result))
,@(when tags-supplied-p
`(:tags ,tags))
- :body (lambda ()
- ;; Use the value of `lexical-binding' in
- ;; the source file when evaluating the body.
- (let ((lexical-binding ,lexical-binding))
- ,@body))))
+ :body (lambda () ,@body)))
',name))))
(defvar ert--find-test-regexp
@@ -780,7 +776,8 @@ This mainly sets up debugger-related bindings."
;; handle ert errors. Once that's done, remove
;; `ert--should-signal-hook'. See Bug#24402 and Bug#11218 for
;; details.
- (let ((debugger (lambda (&rest args)
+ (let ((lexical-binding t)
+ (debugger (lambda (&rest args)
(ert--run-test-debugger test-execution-info
args)))
(debug-on-error t)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master 0f2df36: Run ERT tests with `lexical-binding` bound to `t`,
Mattias Engdegård <=