emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 6fd2a49 1/2: Don't disable transient mark mode when changing imag


From: Lars Ingebrigtsen
Subject: master 6fd2a49 1/2: Don't disable transient mark mode when changing image faces
Date: Fri, 13 Aug 2021 06:29:03 -0400 (EDT)

branch: master
commit 6fd2a4933597776e80b6beb2538a478f1f3c5e8b
Author: Peter Münster <pm@a16n.net>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Don't disable transient mark mode when changing image faces
    
    * lisp/image-dired.el (image-dired-thumb-update-marks): Keep the
    mark state when changing faces. (bug#49999).
---
 lisp/image-dired.el | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 76c7ae9..3c59ef9 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -2360,20 +2360,18 @@ non-nil."
 
 (defun image-dired-thumb-update-marks ()
   "Update the marks in the thumbnail buffer."
-  ;; TODO: only called by image-dired-mouse-toggle-mark but there are
-  ;; certainly other places, where it should be called too.
   (when image-dired-thumb-visible-marks
     (with-current-buffer image-dired-thumbnail-buffer
-      (save-excursion
+      (save-mark-and-excursion
         (goto-char (point-min))
         (let ((inhibit-read-only t))
           (while (not (eobp))
-            (if (image-dired-thumb-file-marked-p)
-                (add-face-text-property
-                 (point) (1+ (point))
-                 'image-dired-thumb-mark)
-              (remove-text-properties (point) (1+ (point))
-                                      '(face image-dired-thumb-mark)))
+            (with-silent-modifications
+              (if (image-dired-thumb-file-marked-p)
+                  (add-face-text-property (point) (1+ (point))
+                                          'image-dired-thumb-mark)
+                (remove-text-properties (point) (1+ (point))
+                                        '(face image-dired-thumb-mark))))
             (forward-char)))))))
 
 (defun image-dired-mouse-toggle-mark-1 ()



reply via email to

[Prev in Thread] Current Thread [Next in Thread]