emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 009bc7c: * lisp/emacs-lisp/cconv.el (cconv--analyze-use): Tune do


From: Stefan Monnier
Subject: master 009bc7c: * lisp/emacs-lisp/cconv.el (cconv--analyze-use): Tune down the warning
Date: Thu, 11 Mar 2021 22:27:50 -0500 (EST)

branch: master
commit 009bc7c9d8bd0074a78ebef73102f600a514172c
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * lisp/emacs-lisp/cconv.el (cconv--analyze-use): Tune down the warning
    
    Don't warn for always-nil bindings if the binding is made explicit.
    Fixes bug#47080.
---
 lisp/emacs-lisp/cconv.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el
index ca641a2..cfb0168 100644
--- a/lisp/emacs-lisp/cconv.el
+++ b/lisp/emacs-lisp/cconv.el
@@ -602,7 +602,8 @@ FORM is the parent form that binds this var."
      (byte-compile-warn
       "%s `%S' not left unused" varkind var))
     ((and (let (or 'let* 'let) (car form))
-          `(,(or `(,var) `(,var nil)) t nil ,_ ,_))
+          `(,`(,var) ;; (or `(,var nil) : Too many false positives: bug#47080
+            t nil ,_ ,_))
      ;; FIXME: Convert this warning to use `macroexp--warn-wrap'
      ;; so as to give better position information.
      (unless (not (intern-soft var))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]