emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 19afd6d: Fix previous commit regarding revert-buffer-function


From: Lars Ingebrigtsen
Subject: master 19afd6d: Fix previous commit regarding revert-buffer-function
Date: Fri, 29 Jan 2021 02:19:24 -0500 (EST)

branch: master
commit 19afd6de25eb836014301009620091be6f0012b0
Author: Sean Whitton <spwhitton@spwhitton.name>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Fix previous commit regarding revert-buffer-function
    
    * simple.el (shell-command, shell-command-on-region): Set
    revert-buffer-function buffer-locally, not globally.  Also, avoid an
    unnecessary call to (current-buffer) by taking advantage of the
    closure (bug#46151).
---
 lisp/simple.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 64ee042..742fc50 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3991,9 +3991,9 @@ impose the use of a shell (with its need to quote 
arguments)."
                          (start-process-shell-command "Shell" buffer command)))
                  (setq mode-line-process '(":%s"))
                   (shell-mode)
-                  (setq revert-buffer-function
-                        (lambda (&rest _)
-                          (async-shell-command command (current-buffer))))
+                  (setq-local revert-buffer-function
+                              (lambda (&rest _)
+                                (async-shell-command command buffer)))
                   (set-process-sentinel proc #'shell-command-sentinel)
                  ;; Use the comint filter for proper handling of
                  ;; carriage motion (see comint-inhibit-carriage-motion).
@@ -4260,9 +4260,9 @@ characters."
                                              buffer))))
             ;; Report the output.
             (with-current-buffer buffer
-              (setq revert-buffer-function
-                    (lambda (&rest _)
-                      (shell-command command)))
+              (setq-local revert-buffer-function
+                          (lambda (&rest _)
+                            (shell-command command)))
               (setq mode-line-process
                     (cond ((null exit-status)
                            " - Error")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]