emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 0eef70a: Minor improvements to FD_SETSIZE overflow checks.


From: Philipp Stephani
Subject: master 0eef70a: Minor improvements to FD_SETSIZE overflow checks.
Date: Wed, 30 Dec 2020 18:32:52 -0500 (EST)

branch: master
commit 0eef70aea892a5b783623a948808b5bc1131c8e0
Author: Philipp Stephani <phst@google.com>
Commit: Philipp Stephani <phst@google.com>

    Minor improvements to FD_SETSIZE overflow checks.
    
    * src/process.c (Fmake_serial_process): Add port to error data.
    (connect_network_socket): Add an explanatory comment.
---
 src/process.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/process.c b/src/process.c
index ba2bb3c..e845e20 100644
--- a/src/process.c
+++ b/src/process.c
@@ -3068,7 +3068,7 @@ usage:  (make-serial-process &rest ARGS)  */)
   fd = serial_open (port);
   p->open_fd[SUBPROCESS_STDIN] = fd;
   if (FD_SETSIZE <= fd)
-    report_file_errno ("Opening serial port", Qnil, EMFILE);
+    report_file_errno ("Opening serial port", port, EMFILE);
   p->infd = fd;
   p->outfd = fd;
   if (fd > max_desc)
@@ -3332,6 +3332,7 @@ connect_network_socket (Lisp_Object proc, Lisp_Object 
addrinfos,
              xerrno = errno;
              continue;
            }
+         /* Reject file descriptors that would be too large.  */
          if (FD_SETSIZE <= s)
            {
              emacs_close (s);



reply via email to

[Prev in Thread] Current Thread [Next in Thread]