emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master f43f1e3: Fix a potential unit test breakage on GNU/Linux.


From: Philipp Stephani
Subject: master f43f1e3: Fix a potential unit test breakage on GNU/Linux.
Date: Wed, 30 Dec 2020 18:06:38 -0500 (EST)

branch: master
commit f43f1e32e92ef341077b4ffdfdd743b1a6d9d284
Author: Philipp Stephani <phst@google.com>
Commit: Philipp Stephani <phst@google.com>

    Fix a potential unit test breakage on GNU/Linux.
    
    * test/src/process-tests.el
    (process-tests/fd-setsize-no-crash/make-process): Allow special exit
    codes that can happen if terminal setup fails in the child process.
---
 test/src/process-tests.el | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index 3a19b6c..590f72f 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -525,7 +525,14 @@ FD_SETSIZE file descriptors (Bug#24325)."
               (dolist (process processes)
                 (while (accept-process-output process))
                 (should (eq (process-status process) 'exit))
-                (should (eql (process-exit-status process) 0))))))))))
+                ;; If there's an error between fork and exec, Emacs
+                ;; will use exit statuses between 125 and 127, see
+                ;; process.h.  This can happen if the child process
+                ;; tries to set up terminal device but fails due to
+                ;; file number limits.  We don't treat this as an
+                ;; error.
+                (should (memql (process-exit-status process)
+                               '(0 125 126 127)))))))))))
 
 (ert-deftest process-tests/fd-setsize-no-crash/make-pipe-process ()
   "Check that Emacs doesn't crash when trying to use more than



reply via email to

[Prev in Thread] Current Thread [Next in Thread]