emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

feature/integration-of-dictionary-el a25a12d 12/17: Use when where else


From: Torsten Hilbrich
Subject: feature/integration-of-dictionary-el a25a12d 12/17: Use when where else case returns nil
Date: Mon, 14 Dec 2020 05:46:39 -0500 (EST)

branch: feature/integration-of-dictionary-el
commit a25a12ddaf61389030a1afaa535d5563856cfc70
Author: Torsten Hilbrich <torsten.hilbrich@gmx.net>
Commit: Torsten Hilbrich <torsten.hilbrich@gmx.net>

    Use when where else case returns nil
    
    * lisp/net/dictionary-connection.el (dictionary-connection-status,
    dictionary-connection-close): Instead of returning nil in the else case
    of the if just use when.
    
    Was suggested by Stefan Kangas.
---
 lisp/net/dictionary-connection.el | 42 +++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/lisp/net/dictionary-connection.el 
b/lisp/net/dictionary-connection.el
index c762b35..0d93d97 100644
--- a/lisp/net/dictionary-connection.el
+++ b/lisp/net/dictionary-connection.el
@@ -85,31 +85,29 @@ nil: argument is no connection object
 'up: connection is open and buffer is existing
 'down: connection is closed
 'alone: connection is not associated with a buffer"
-  (if (dictionary-connection-p connection)
-      (let ((process (dictionary-connection-process connection))
-           (buffer (dictionary-connection-buffer connection)))
-       (if (not process)
-           'none
-         (if (not (buffer-live-p buffer))
-             'alone
-           (if (not (eq (process-status process) 'open))
-               'down
-             'up))))
-    nil))
+  (when (dictionary-connection-p connection)
+    (let ((process (dictionary-connection-process connection))
+          (buffer (dictionary-connection-buffer connection)))
+      (if (not process)
+          'none
+        (if (not (buffer-live-p buffer))
+            'alone
+          (if (not (eq (process-status process) 'open))
+              'down
+            'up))))))
 
 (defun dictionary-connection-close (connection)
   "Force closing of the connection."
-  (if (dictionary-connection-p connection)
-      (progn
-       (let ((buffer (dictionary-connection-buffer connection))
-             (process (dictionary-connection-process connection)))
-         (if process
-             (delete-process process))
-         (if buffer
-             (kill-buffer buffer))
-
-         (dictionary-connection-set-process connection nil)
-         (dictionary-connection-set-buffer connection nil)))))
+  (when (dictionary-connection-p connection)
+    (let ((buffer (dictionary-connection-buffer connection))
+          (process (dictionary-connection-process connection)))
+      (if process
+          (delete-process process))
+      (if buffer
+          (kill-buffer buffer))
+
+      (dictionary-connection-set-process connection nil)
+      (dictionary-connection-set-buffer connection nil))))
 
 (defun dictionary-connection-send (connection data)
   "Send `data' to the process."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]