emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 932cb10: * lisp/emacs-lisp/package.el (package-strip-rcs-id): Don


From: Stefan Monnier
Subject: master 932cb10: * lisp/emacs-lisp/package.el (package-strip-rcs-id): Don't ignore errors
Date: Fri, 20 Nov 2020 19:28:41 -0500 (EST)

branch: master
commit 932cb10761b9f249c87d7c19778873691f2a5d46
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * lisp/emacs-lisp/package.el (package-strip-rcs-id): Don't ignore errors
    
    Ignoring errors here just postpones the error and replaces a clear
    "invalid version syntax" with a confusing "package lacks a version".
---
 lisp/emacs-lisp/package.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index d78a1a2..9c37ce4 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2112,8 +2112,7 @@ Otherwise return nil."
   (when str
     (when (string-match "\\`[ \t]*[$]Revision:[ \t]+" str)
       (setq str (substring str (match-end 0))))
-    (ignore-errors
-      (if (version-to-list str) str))))
+    (if (version-to-list str) str)))
 
 (declare-function lm-homepage "lisp-mnt" (&optional file))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]