[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/completions-highlight-modifications bfb8a71 21/25: Add ignore-er
From: |
Jimmy Aguilar Mena |
Subject: |
feature/completions-highlight-modifications bfb8a71 21/25: Add ignore-errors when executing from minibuffer |
Date: |
Fri, 20 Nov 2020 13:28:35 -0500 (EST) |
branch: feature/completions-highlight-modifications
commit bfb8a712dd16fe495ba2b190f88c45f5a190c610
Author: Jimmy Aguilar Mena <spacibba@aol.com>
Commit: Jimmy Aguilar Mena <spacibba@aol.com>
Add ignore-errors when executing from minibuffer
This asserts that the hooks are executed in some cases like when EOB.
*
lisp/completions-highlight (completions-highlight-completions-visible-p)
: New function
---
lisp/completions-highlight.el | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lisp/completions-highlight.el b/lisp/completions-highlight.el
index 7e7ea2c..9ce83e6 100644
--- a/lisp/completions-highlight.el
+++ b/lisp/completions-highlight.el
@@ -106,16 +106,20 @@ buffer is shown and updated."
(move-overlay completions-highlight-overlay obeg oend)
(minibuffer-completion-set-suffix choice)))
+(defsubst completions-highlight-completions-visible-p ()
+ "Return t if *Completions* is visible."
+ (and (window-live-p minibuffer-scroll-window)
+ (eq t (frame-visible-p (window-frame minibuffer-scroll-window)))))
+
;; Minibuffer side commands
(defmacro with-minibuffer-scroll-window (&rest body)
"Execute BODY in *Completions* buffer and return to `minibuffer'.
The command is only executed if the `minibuffer-scroll-window' is
alive and active."
- `(and (window-live-p minibuffer-scroll-window)
- (eq t (frame-visible-p (window-frame minibuffer-scroll-window)))
+ `(and (completions-highlight-completions-visible-p)
(with-selected-window minibuffer-scroll-window
- ,@body
- (completions-highlight-this-completion))))
+ (ignore-errors ,@body)
+ (run-hooks 'post-command-hook))))
(defun minibuffer-next-completion (n)
"Execute `next-completion' in *Completions*.
- feature/completions-highlight-modifications f19039c 14/25: Improve completions-highlight description in file header., (continued)
- feature/completions-highlight-modifications f19039c 14/25: Improve completions-highlight description in file header., Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications ce8b5b2 17/25: Simplify and rely more in the post-command-hook, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 3f0f13e 18/25: Add backtab commands., Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 6ea2c5c 20/25: Fixes:, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 25f23b1 25/25: Add try to close completions more often like zsh., Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 5cf9dd6 11/25: Add autoload decorator., Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 6cea893 07/25: Fix corner case when going out of bounds, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications e143246 10/25: Simplify overlay handling, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications ab1e2e6 15/25: Add custom variable completions-highlight-autoselect., Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 10359ba 19/25: Fix previous commit, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications bfb8a71 21/25: Add ignore-errors when executing from minibuffer,
Jimmy Aguilar Mena <=
- feature/completions-highlight-modifications 3319dcc 22/25: New command minibuffer-choose-completion, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 6369e59 23/25: Other changes:, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications c990a28 24/25: Simplify and add custom, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 42f47e7 06/25: Fix recursive set-keymap-parent in completions-highlight., Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 644d5e5 08/25: Simplify numeric argument, Jimmy Aguilar Mena, 2020/11/20
- feature/completions-highlight-modifications 268170e 16/25: Define completions-highlight face and group, Jimmy Aguilar Mena, 2020/11/20