[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/completions-highlight-modifications a686211 10/18: Simplify over
From: |
Jimmy Aguilar Mena |
Subject: |
feature/completions-highlight-modifications a686211 10/18: Simplify overlay handling |
Date: |
Wed, 18 Nov 2020 22:30:35 -0500 (EST) |
branch: feature/completions-highlight-modifications
commit a68621187311f1d5bf6d79e684d875e478cb37cf
Author: Jimmy Aguilar Mena <spacibba@aol.com>
Commit: Jimmy Aguilar Mena <spacibba@aol.com>
Simplify overlay handling
* lisp/completions-highlight.el (completions-highlight-overlay) :
created on load.
(completions-highlight-completions-pre-command-hook) : Don't move
overlay here.
(completions-highlight-minibuffer-pre-command-hook) : Use delete overlay
instead of conditional
(completions-highlight-mode) : Use overlay-put here instead of the setup.
---
lisp/completions-highlight.el | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lisp/completions-highlight.el b/lisp/completions-highlight.el
index 31442da..f9d85bd 100644
--- a/lisp/completions-highlight.el
+++ b/lisp/completions-highlight.el
@@ -37,7 +37,7 @@
(require 'simple)
(require 'minibuffer)
-(defvar completions-highlight-overlay nil
+(defvar completions-highlight-overlay (make-overlay 0 0)
"Overlay to use when `completion-highlight-mode' is enabled.")
(defvar minibuffer-tab-through-completions-function-save nil
@@ -223,7 +223,6 @@ should be assigned to
completion-in-minibuffer-scroll-window."
(defun completions-highlight-completions-pre-command-hook ()
"Function `pre-command-hook' to use only in the *Completions."
- (move-overlay completions-highlight-overlay 0 0)
(minibuffer-completion-set-suffix ""))
(defun completions-highlight-minibuffer-pre-command-hook ()
@@ -234,25 +233,24 @@ should be assigned to
completion-in-minibuffer-scroll-window."
(defun completions-highlight-setup ()
"Function to call when enabling the `completion-highlight-mode' mode.
It is called when showing the *Completions* buffer."
+ (delete-overlay completions-highlight-overlay)
(with-current-buffer standard-output
(when (string= (buffer-name) "*Completions*")
- (unless (overlayp completions-highlight-overlay)
- (setq completions-highlight-overlay (make-overlay 0 0))
- (overlay-put completions-highlight-overlay 'face 'highlight))
(add-hook 'pre-command-hook
#'completions-highlight-completions-pre-command-hook nil t)
(add-hook 'isearch-mode-end-hook
#'completions-highlight-this-completion nil t)
+ ;; Add completions-highlight-completions-map to *Completions*
(use-local-map (make-composed-keymap
completions-highlight-completions-map
(current-local-map)))))
(add-hook 'pre-command-hook
#'completions-highlight-minibuffer-pre-command-hook nil t)
- ;; Add completions-highlight-minibuffer-map bindings to minibuffer map
+ ;; Add completions-highlight-minibuffer-map bindings to minibuffer
(use-local-map (make-composed-keymap
completions-highlight-minibuffer-map (current-local-map))))
@@ -263,7 +261,9 @@ It is called when showing the *Completions* buffer."
(if completions-highlight-mode
(progn
- (setq minibuffer-tab-through-completions-function-save
+ (overlay-put completions-highlight-overlay 'face 'highlight)
+
+ (setq minibuffer-tab-through-completions-function-save
minibuffer-tab-through-completions-function)
(setq minibuffer-tab-through-completions-function
- branch feature/completions-highlight-modifications created (now ff46a8f), Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications c6a25d8 01/18: Insert some modifications to implement completions highlighting., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications f132cc3 02/18: Document the changes in the API for Completions., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications d812e76 05/18: Improve keymap handling., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 8647012 06/18: Fix recursive set-keymap-parent in completions-highlight., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 8f3e475 03/18: Add completions-highlight-mode initial implementation., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications a6e73e8 04/18: Fix initial comment in completions-highlight file., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 8a60d7d 08/18: Simplify numeric argument, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications a686211 10/18: Simplify overlay handling,
Jimmy Aguilar Mena <=
- feature/completions-highlight-modifications 34570e1 14/18: Improve completions-highlight description in file header., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications bfe4747 12/18: Add parent maps, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 6db2c4a 17/18: Simplify and rely more in the post-command-hook, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications d397d2b 13/18: Add # to function bindings, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications cb02cb6 11/18: Add autoload decorator., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 9fe2441 15/18: Add custom variable completions-highlight-autoselect., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications ff46a8f 18/18: Add backtab commands., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 71f60b6 07/18: Fix corner case when going out of bounds, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications ac93fdb 16/18: Define completions-highlight face and group, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications f3ad5c1 09/18: Simplify setting keymaps., Jimmy Aguilar Mena, 2020/11/18