emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 3289b96: Remove test for return value of set-keymap-parent


From: Stefan Kangas
Subject: master 3289b96: Remove test for return value of set-keymap-parent
Date: Mon, 9 Nov 2020 05:49:50 -0500 (EST)

branch: master
commit 3289b96abd12058439f02e84415793acb44a733b
Author: Stefan Kangas <stefan@marxist.se>
Commit: Stefan Kangas <stefan@marxist.se>

    Remove test for return value of set-keymap-parent
    
    * test/src/keymap-tests.el
    (keymap-keymap-set-parent/returns-parent): Remove test for the return
    value of set-keymap-parent.  It is not clear that returning the value
    is a very good idea.
    Problem pointed out by Stefan Monnier <monnier@iro.umontreal.ca>.
---
 test/src/keymap-tests.el | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/test/src/keymap-tests.el b/test/src/keymap-tests.el
index 8331a41..e3dd842 100644
--- a/test/src/keymap-tests.el
+++ b/test/src/keymap-tests.el
@@ -48,10 +48,6 @@
     (set-keymap-parent map help-mode-map)
     (should (equal (keymap-parent map) help-mode-map))))
 
-(ert-deftest keymap-keymap-set-parent/returns-parent ()
-  (let ((map (make-keymap)))
-    (should (equal (set-keymap-parent map help-mode-map) help-mode-map))))
-
 (ert-deftest keymap-copy-keymap/is-equal ()
   (should (equal (copy-keymap help-mode-map) help-mode-map)))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]