emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master ecec9a2: Fix saving a face setting with Customize


From: Mauro Aranda
Subject: master ecec9a2: Fix saving a face setting with Customize
Date: Sun, 1 Nov 2020 08:11:36 -0500 (EST)

branch: master
commit ecec9a259b13d88fa23dde078fba99ae78ef79c7
Author: Mauro Aranda <maurooaranda@gmail.com>
Commit: Mauro Aranda <maurooaranda@gmail.com>

    Fix saving a face setting with Customize
    
    * lisp/cus-edit.el (custom-face-save): Make sure we back up into the
    :shown-value property what the user has edited so far, if we are going
    to recreate the custom-face widget.  (Bug#44331)
---
 lisp/cus-edit.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 769a69a..3eef446 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -3931,7 +3931,12 @@ Optional EVENT is the location for the menu."
         (custom-face-mark-to-save widget)
       ;; The user is working on only a selected terminal type;
       ;; make sure we save the entire spec to `custom-file'. (Bug #40866)
+      ;; If recreating a widget that may have been edited by the user, remember
+      ;; to always save the edited value into the :shown-value property, so
+      ;; we use that value for the recreated widget.  (Bug#44331)
+      (widget-put widget :shown-value (custom-face-widget-to-spec widget))
       (custom-face-edit-all widget)
+      (widget-put widget :shown-value nil) ; Reset it after we used it.
       (custom-face-mark-to-save widget)
       (if (eq form 'selected)
           (custom-face-edit-selected widget)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]