emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master b31e48d: Make read-char-choice less modal


From: Lars Ingebrigtsen
Subject: master b31e48d: Make read-char-choice less modal
Date: Mon, 12 Oct 2020 22:59:21 -0400 (EDT)

branch: master
commit b31e48d4efb030b59a9058796c2da53357c379a3
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Make read-char-choice less modal
    
    * lisp/subr.el (read-char-choice): Use `read-char-from-minibuffer'
    here (bug#42708) so that we're not as modal (and users can copy
    the help buffer, if they should so want).
---
 lisp/subr.el | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index 07cab59..867c9f0 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -2622,7 +2622,15 @@ keyboard-quit events while waiting for a valid input."
          (unless (get-text-property 0 'face prompt)
            (setq prompt (propertize prompt 'face 'minibuffer-prompt)))
          (setq char (let ((inhibit-quit inhibit-keyboard-quit))
-                      (read-key prompt)))
+                      (read-char-from-minibuffer
+                        prompt
+                        ;; If we have a dynamically bound `help-form'
+                        ;; here, then the `C-h' (i.e., `help-char')
+                        ;; character should output that instead of
+                        ;; being a command char.
+                        (if help-form
+                            (cons help-char chars)
+                          chars))))
          (and show-help (buffer-live-p (get-buffer helpbuf))
               (kill-buffer helpbuf))
          (cond



reply via email to

[Prev in Thread] Current Thread [Next in Thread]